874612 - Make nsIXPConnectWrappedNative methods take HandleId instead of jsid

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Because getting a JSContext can maybe gc, or so the rooting analysis thinks, so we can't root inside them.

The good news is that passing in a handle is easy.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make some nsIXPConnectWrappedNative methods take a Handle<jsid> instead of a jsid.

We could also try to change nsIXPCScriptable to take handles here, but I'd rather work on removing them all instead

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 752366 [details] [diff] [review]
Make some nsIXPConnectWrappedNative methods take a Handle<jsid> instead of a jsid.

Review of attachment 752366 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCWrappedNative.cpp
@@ +2998,5 @@
>      return NS_OK;
>  }
>  
> +/* XPCNativeInterface FindInterfaceWithMember (in JSHandleId name); */
> +NS_IMETHODIMP XPCWrappedNative::FindInterfaceWithMember(JS::HandleId name,

Just HandleId in XPConnect cpp files, since we should be using namespace JS. Here and below.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99e821df3d61 with that change.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/99e821df3d61