87468 - Minor Xprint cleanup...

Status: RESOLVED FIXED

(Core Graveyard :: Printing: Xprint, defect)

Description

[Roland Mainz]

More or less a loose followup from bug 87148:

ToDo:
- Fix Xprint crash in Xlib-toolkit due use of shared xlibrgb (the idea was good
- but it does not work yet...). Currently Xlib-toolkit and Xprint needs each
their own set of global variables. This will be fixed by bug 85527 ("Turn
xlibrgb into a shared library")...
- Increase GC-cache size in Xprint land from 10 to 16 to improve printing speed
and complex page rendering
- Remove "#define DEBUG 1" in Xlib-toolkit nsGCCache.h - no DEBUG stuff in
non-debug builds, please
- remove cls's workaround for duplicate symbols...
-- snip --
-#ifdef _IMPL_NS_XPRINT
-#define nsGCCache     nsGCCacheXlib
-#define GCCacheEntry  GCCacheEntryXlib
-#endif
-- snip --
...and replaced it with s/nsGCCache/nsGCCacheXlib/ and
s/GCCacheEntry/GCCacheEntryXlib/

Attachment http://bugzilla.mozilla.org/showattachment.cgi?attach_id=39668 (see
bug 87148) is more or less the complete fix except that it has to be adopted
after patch for bug 87148 has been checked-in.

CC:'ing cls as Makefile.in&&build expert and pocemit(=timecop) as Xlib-toolkit
expert...

Comment 1

[Roland Mainz]

Swapping QA<-->owner, setting milestone, adding dependicy to bug 87148...

Comment 2

[cls]

What's the bug for the xprint crash with xlib?  Glancing at xlibrgb.c, I don't
see how making it a shared library is going to fix things.  

Comment 3

[Roland Mainz]

> What's the bug for the xprint crash with xlib? 

See bug 87582 ("Xlib-toolkit Mozilla crashes while printing via Xprint")...

> Glancing at xlibrgb.c, I don't
> see how making it a shared library is going to fix things.

Description in bug 87582 explains this. 
Short: Xlib-toolkit and Xprint module are currently both linking against
xlibrgb.so - and overwrite the |Display *| var in it (and/or other global vars).
BAD. Fix: Introduce a new API which stores these variables in a "handle" instead
of using global variables. bug 85527 will implement that...

The workaound for now is to compile xlibrgb.c into Xprint module - I did this in
the past... - but somehow I saw the xlibrgb.so in xlib/Makefile.in and thought
it may be a good idea to use that instead of compiling xlibrgb.c into the Xprint
module. This causes bug 87582. 
And because this is not the first time I am doing this... that's why I am going
to add a WARNING into xprint/Makefile.in to remind _me_ that this is a _BAD_
idea until bug 85527 has been implemented.

Comment 4

[Roland Mainz]

1. Accepting bug
2. Removing item "Fix Xprint crash in Xlib-toolkit due use of shared xlibrgb"
from ToDO list. bug 87582 ("Xlib-toolkit Mozilla crashes while printing via
Xprint") will handle this.
3. More ToDo:
- The following files are no longer in use and can be removed (or moved to
attic):
mozilla/gfx/src/xprint/nsFontMetricsXP.cpp
mozilla/gfx/src/xprint/nsFontMetricsXP.h
mozilla/gfx/src/xprint/nsRegionXP.cpp
mozilla/gfx/src/xprint/nsRegionXP.h
 

Comment 5

[Roland Mainz]

Attachment: Patch for 2001-06-24-08-trunk

Comment 6

[Roland Mainz]

Filed patch for 2001-06-24-08-trunk
Comments:
- Fixed all issues in ToDo list described here
- #include "nsImageXlib.h" // isn't required anymore - this seems to be a
side-effect of picking the "right" nsGCCache.h file (Xlib-nsGCCache.h instead of
GTK+-nsGCCache.h)...

Requesting r=/sr= ...

Comment 7

[pocemit]

The patch is a simple class rename
r=pocemit

Comment 8

[Darin Fisher]

looks good to me.. sr=darin

Comment 9

[Roland Mainz]

darin/pocemit:
Thanks!!

----

CC:'ing [e-mail] for checkin of this patch...

Comment 10

[Mike Kaply [:mkaply]]

Fix checked in.