874737 - [Camera] Improper Camera preview in landscape mode for browser pick activity

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

Description

[Leo]

1. Title : Improper Camera preview in landscape mode for browser pick activity
2. Precondition : Mobile phone should be conencted to internet
3. Tester's Action : 1. Idle > Open Browser > Twitter > Log in;
                     2. Select "New tweet" icon > Select camera icon;
                     3. Select "Camera" > Change to landscape mode;
 
4. Detailed Symptom (ENG.) : Once the camera is rotated to landscape mode, complete camera UI and preview buffer is getting roated which is not expected. This is happening only when the pick activity is launched from browser app. If pick activity is launched from wallpaper and email this issue is not reproducible.
5. Expected : Camera preview should work normally when orientation of phone is changed.
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: f2abcfcf79492ae1ef152e2d2c94ff4d25ffe5a5
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Video Attachment

Issue scenario

Comment 2

[Dale Harvey (:daleharvey)]

Hey gjyothiprasad

Sorry I was travelling while you messaged me, I will take a look at what is causing this today, it seems like it will be the window manager and gecko not handling locked orientations inside activities properly

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Comparing to lunch camera by other application and found the camera UI/menu bar won't change to landscape mode.

Comment 4

[Leo]

As discussed in San diego work week, marking this leo+

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

This is a missed piece in window manager.
We don't lock the orientation for opened inline activity.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

In order not to pollute window manager,
my quick solution is to let the inline activity frame itself(camera in this case) to reqeust the orientation lock when it's opened.

This is not the general solution though.
Locking multi inline activities is somewhat complex.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10072

Still try to have a general solution: lock orientation for inline activity

Comment 8

[[:fabrice] Fabrice Desré]

Comment on attachment 755293 [details]
https://github.com/mozilla-b2g/gaia/pull/10072

That look fine to me and works well, but I'm not familiar enough with the window manager code to give a r+

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Let me poke Tim for the review...(/poke)

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

master
https://github.com/mozilla-b2g/gaia/commit/0c0e0f823d73318289c12187992ec1b29b6da795

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0c0e0f823d73318289c12187992ec1b29b6da795 to:
v1-train: 8fa086b6bbc875adbf67f75061b38176814b25e4

Comment 12

[Angela Hubenya]

UCID: CAMERA-007