Closed
Bug 874758
Opened 13 years ago
Closed 13 years ago
Switch DOMStringMap to [OverrideBuiltins]
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
6.09 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Now that bug 870514 is done, we should just do this. It's saner behavior _and_ now faster.
Note that this matches the Chrome and Safari behavior too.
I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=19611 on the spec.
|
Assignee | |
Comment 1•13 years ago
|
||
Peter, I assume the tracing here will need some sort of fixes or something, like the HTMLDocument stuff?
Attachment #752529 -
Flags: review?(peterv)
|
||
Updated•13 years ago
|
Attachment #752529 -
Flags: review?(peterv) → review+
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 752529 [details] [diff] [review]
Make DOMStringMap use [OverrideBuiltins].
Review of attachment 752529 [details] [diff] [review]:
-----------------------------------------------------------------
Actually, I'll doublecheck the tracing
Attachment #752529 -
Flags: review+ → review?(peterv)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 752529 [details] [diff] [review]
Make DOMStringMap use [OverrideBuiltins].
Review of attachment 752529 [details] [diff] [review]:
-----------------------------------------------------------------
The expando stuff seems fine. It'll have the same bugs as HTMLDocument (if there are any). I suppose you want to do the ExpandAndGeneration::Unlink in a separate bug?
Attachment #752529 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Yeah, the unlink thing will happen in bug 883887.
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a535b327054f
I added a test too.
Flags: in-testsuite+
Whiteboard: [need review]
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•