If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Switch DOMStringMap to [OverrideBuiltins]

RESOLVED FIXED in mozilla24

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla24
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Now that bug 870514 is done, we should just do this.  It's saner behavior _and_ now faster.

Note that this matches the Chrome and Safari behavior too.

I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=19611 on the spec.
Created attachment 752529 [details] [diff] [review]
Make DOMStringMap use [OverrideBuiltins].

Peter, I assume the tracing here will need some sort of fixes or something, like the HTMLDocument stuff?
Attachment #752529 - Flags: review?(peterv)
Attachment #752529 - Flags: review?(peterv) → review+
Comment on attachment 752529 [details] [diff] [review]
Make DOMStringMap use [OverrideBuiltins].

Review of attachment 752529 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, I'll doublecheck the tracing
Attachment #752529 - Flags: review+ → review?(peterv)
Attachment #752529 - Flags: review?(peterv) → review?(peterv)
Comment on attachment 752529 [details] [diff] [review]
Make DOMStringMap use [OverrideBuiltins].

Review of attachment 752529 [details] [diff] [review]:
-----------------------------------------------------------------

The expando stuff seems fine. It'll have the same bugs as HTMLDocument (if there are any). I suppose you want to do the ExpandAndGeneration::Unlink in a separate bug?
Attachment #752529 - Flags: review?(peterv) → review+
Yeah, the unlink thing will happen in bug 883887.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a535b327054f

I added a test too.
Flags: in-testsuite+
Whiteboard: [need review]

Comment 6

4 years ago
https://hg.mozilla.org/mozilla-central/rev/a535b327054f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.