Closed Bug 87493 Opened 24 years ago Closed 24 years ago

PR_Accept() should retry after getting ECONNABORTED.

Categories

(NSPR :: NSPR, defect, P2)

4.0.2
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(2 files)

The ECONNABORTED error of accept() means that a pending connect request in the listen queue was aborted by the peer before we could accept the connection. This is not a fatal error. If the listening socket is blocking, PR_Accept() should handle ECONNABORTED the same way it handles EAGAIN or EWOULDBLOCK and loop back to retry accept().
Attached patch Proposed patch.Splinter Review
I checked in the proposed patch v2 on the trunk. I only fixed the Unix implementation of PR_Accept(). I don't know whether Winsock's accept() would also fail with the WSAECONNABORTED error under the same condition. I guess we will fix it when such errors are observed or reported by a customer.
Status: NEW → RESOLVED
Closed: 24 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → 4.2
OS: Windows 98 → All
Hardware: PC → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: