Work - Use new lock icon for indicating SSL status

RESOLVED FIXED

Status

Firefox for Metro
App Bar
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: TimAbraldes, Assigned: TimAbraldes)

Tracking

({feature})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=work)

Attachments

(1 attachment, 1 obsolete attachment)

New "lock" icons are available in bug 811390.  We should switch to using them instead of the placeholder that we are currently using.
Created attachment 752965 [details] [diff] [review]
patch v1

This patch replaces existing, incorrect lock icons with the new ones, and updates Windows 8 Style Firefox to use the new ones.
Attachment #752965 - Flags: review?(mbrubeck)
Comment on attachment 752965 [details] [diff] [review]
patch v1

Review of attachment 752965 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/theme/browser.css
@@ -291,4 @@
>  }
>  
>  #identity-box-inner.verifiedDomain > #identity-icon {
> -  list-style-image: url(chrome://browser/skin/images/locked-hdpi.png);

It looks like locked-hdpi.png and unlocked-hdpi.png are unused now; please delete the files and remove them from theme/jar.mn.
Attachment #752965 - Flags: review?(mbrubeck) → review+
Created attachment 753356 [details] [diff] [review]
Patch v2

Review comments addressed
Attachment #752965 - Attachment is obsolete: true
Attachment #753356 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/728c7eeda1d7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.