Closed Bug 875018 Opened 8 years ago Closed 6 years ago

SimplePush: Switch to using DOM Promises for navigator.push API

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(1 file)

Before unleashing push on the web, would it be a good idea to complete the switch to Futures? The implementation change itself should be trivial. My main concern is the migration path for B2G 1.1 which is likely to have the DOMRequest based implementation.
Summary: SimplePush: Switch to using DOM Futures for navigator.push API → SimplePush: Switch to using DOM Promises for navigator.push API
Patch ready. Waiting on Promises to be exposed in B2G.
Attachment #786639 - Flags: superreview?(jonas)
Attachment #786639 - Flags: review?(doug.turner)
Attachment #786639 - Flags: feedback?(willyaranda)
Comment on attachment 786639 [details] [diff] [review]
SimplePush uses Promises.

Review of attachment 786639 [details] [diff] [review]:
-----------------------------------------------------------------

does this break existing users?
Attachment #786639 - Flags: review?(doug.turner) → review+
(In reply to Doug Turner (:dougt) from comment #2)
> Comment on attachment 786639 [details] [diff] [review]
> SimplePush uses Promises.
> 
> Review of attachment 786639 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> does this break existing users?

Yea, can't land until we have a clear decision on migration path from DOMRequest. See https://bugzil.la/839838 and the discussion in https://groups.google.com/d/msg/mozilla.dev.webapi/4O_ffcuLjdE/e77aUBlhv_IJ
Comment on attachment 786639 [details] [diff] [review]
SimplePush uses Promises.

Review of attachment 786639 [details] [diff] [review]:
-----------------------------------------------------------------

I believe Doug was worried about compatibility breakage with this change.

I think a safer approach would be to add Promise-syntax to DOMRequest and then warn whenever the DOMRequest part was used.
Attachment #786639 - Flags: superreview?(jonas) → superreview-
WONTFIX since the standard Push API we and other vendors are working on will use Promises.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.