875018 - SimplePush: Switch to using DOM Promises for navigator.push API

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Before unleashing push on the web, would it be a good idea to complete the switch to Futures? The implementation change itself should be trivial. My main concern is the migration path for B2G 1.1 which is likely to have the DOMRequest based implementation.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: SimplePush uses Promises.

Patch ready. Waiting on Promises to be exposed in B2G.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 786639 [details] [diff] [review]
SimplePush uses Promises.

Review of attachment 786639 [details] [diff] [review]:
-----------------------------------------------------------------

does this break existing users?

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Doug Turner (:dougt) from comment #2)
> Comment on attachment 786639 [details] [diff] [review]
> SimplePush uses Promises.
> 
> Review of attachment 786639 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> does this break existing users?

Yea, can't land until we have a clear decision on migration path from DOMRequest. See https://bugzil.la/839838 and the discussion in https://groups.google.com/d/msg/mozilla.dev.webapi/4O_ffcuLjdE/e77aUBlhv_IJ

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 786639 [details] [diff] [review]
SimplePush uses Promises.

Review of attachment 786639 [details] [diff] [review]:
-----------------------------------------------------------------

I believe Doug was worried about compatibility breakage with this change.

I think a safer approach would be to add Promise-syntax to DOMRequest and then warn whenever the DOMRequest part was used.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

WONTFIX since the standard Push API we and other vendors are working on will use Promises.