Closed
Bug 875155
Opened 13 years ago
Closed 13 years ago
Convert TimeEvent to WebIDL binding
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: emk, Assigned: emk)
Details
Attachments
(2 files)
|
7.63 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
|
9.25 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #753049 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #753050 -
Flags: review?(bugs)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 753049 [details] [diff] [review]
Make bug 809674 test self-contained
Review of attachment 753049 [details] [diff] [review]:
-----------------------------------------------------------------
looks great, thanks. r=bholley
::: js/xpconnect/tests/idl/xpctest_bug809674.idl
@@ +7,5 @@
> +#include "nsISupports.idl"
> +/*
> + * This defines the interface for a test object.
> + *
> + */
Weird commenting.
Attachment #753049 -
Flags: review?(bobbyholley+bmo) → review+
|
||
Comment 4•13 years ago
|
||
Comment on attachment 753050 [details] [diff] [review]
Convert TimeEvent to WebIDL
Why you need the empty dtor?
Attachment #753050 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to Bobby Holley (:bholley) (PTO thurs/fri) from comment #3)
> ::: js/xpconnect/tests/idl/xpctest_bug809674.idl
> @@ +7,5 @@
> > +#include "nsISupports.idl"
> > +/*
> > + * This defines the interface for a test object.
> > + *
> > + */
>
> Weird commenting.
Changed the comment.
(In reply to Olli Pettay [:smaug] from comment #4)
> Comment on attachment 753050 [details] [diff] [review]
> Convert TimeEvent to WebIDL
>
> Why you need the empty dtor?
Probably not. removed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ca7d5f18560
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d8193c572ec
Flags: in-testsuite-
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ca7d5f18560
https://hg.mozilla.org/mozilla-central/rev/5d8193c572ec
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•