Crash upon loading a page with a track element

RESOLVED FIXED in mozilla24

Status

()

Core
Audio/Video
--
critical
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: reyre, Assigned: reyre)

Tracking

(Blocks: 1 bug, {crash})

Trunk
mozilla24
crash
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

4 years ago
Created attachment 753063 [details]
Back trace

When loading a page with a track element program receives an EXC_BAD_ACCESS error.
(Assignee)

Updated

4 years ago
Assignee: nobody → rick.eyre
Blocks: 629350
Depends on: 833382
(Assignee)

Comment 1

4 years ago
Created attachment 753116 [details] [diff] [review]
Bug 875169v1
Attachment #753116 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

4 years ago
Comment on attachment 753116 [details] [diff] [review]
Bug 875169v1

Actually, this doesn't solve the root problem. Will post back...
Attachment #753116 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

4 years ago
Comment on attachment 753116 [details] [diff] [review]
Bug 875169v1

Actually, this might be a reasonable way of fixing this.
Attachment #753116 - Flags: review?(bzbarsky)

Updated

4 years ago
Severity: normal → critical
Crash Signature: [@ mozilla::dom::DOMString::AsAString()]
Keywords: crash
(Assignee)

Comment 4

4 years ago
Created attachment 753135 [details]
Back trace (more complete)
Attachment #753063 - Attachment is obsolete: true
Comment on attachment 753116 [details] [diff] [review]
Bug 875169v1

Please just add overloads of GetSrclang and GetLabel that use nsString& as the outparam and get rid of the DOMString goop in this method altogether.
Attachment #753116 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 6

4 years ago
Created attachment 753592 [details] [diff] [review]
Patch version 2

- HTMLTrackElement() now has overloaded functions for GetLabel() and GetSrclang() that take nsString&
- HTMLTrackElement::CreateTextTrack() now uses these functions when creating a new TextTrack.
Attachment #753116 - Attachment is obsolete: true
Attachment #753592 - Flags: review?(bzbarsky)
(Assignee)

Updated

4 years ago
Attachment #753592 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

4 years ago
Created attachment 753593 [details]
Patch version 2

- HTMLTrackElement() now has overloaded functions for GetLabel() and GetSrclang() that take nsString&
- HTMLTrackElement::CreateTextTrack() now uses these functions when creating a new TextTrack.
Attachment #753592 - Attachment is obsolete: true
Attachment #753593 - Flags: review?(bzbarsky)
(Assignee)

Comment 8

4 years ago
Created attachment 753594 [details] [diff] [review]
Patch version 2

Wow... well this should be the right attachment. Sorry about that.
Attachment #753593 - Attachment is obsolete: true
Attachment #753593 - Flags: review?(bzbarsky)
Attachment #753594 - Flags: review?(bzbarsky)
Comment on attachment 753594 [details] [diff] [review]
Patch version 2

r=me.
Attachment #753594 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

4 years ago
Blocks: 833386
(Assignee)

Comment 10

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=e2a478f63c6f
New try push on top of incoming including the patches from bug 833382 and 881432.

https://tbpl.mozilla.org/?tree=Try&rev=81de1fc9d46c
(Assignee)

Comment 12

4 years ago
I've starred most of the ones that I could find bugs on. The only one lest is the reftest crash on OS X.

I've spun up a build to test repeatability: https://tbpl.mozilla.org/?tree=Try&rev=5b34607a261b
Cipc failure from my try in comment #11 isn't repeatable, so looks like we're clean. Let me know when you're ready to land.
(Assignee)

Comment 14

4 years ago
Looks good to me. Land ho!
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbab527d8a4f
https://hg.mozilla.org/mozilla-central/rev/fbab527d8a4f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.