Closed Bug 875169 Opened 6 years ago Closed 6 years ago

Crash upon loading a page with a track element

Categories

(Core :: Audio/Video, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: reyre, Assigned: reyre)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(2 files, 4 obsolete files)

Attached file Back trace (obsolete) —
When loading a page with a track element program receives an EXC_BAD_ACCESS error.
Assignee: nobody → rick.eyre
Blocks: webvtt
Depends on: 833382
Attached patch Bug 875169v1 (obsolete) — Splinter Review
Attachment #753116 - Flags: review?(bzbarsky)
Comment on attachment 753116 [details] [diff] [review]
Bug 875169v1

Actually, this doesn't solve the root problem. Will post back...
Attachment #753116 - Flags: review?(bzbarsky)
Comment on attachment 753116 [details] [diff] [review]
Bug 875169v1

Actually, this might be a reasonable way of fixing this.
Attachment #753116 - Flags: review?(bzbarsky)
Severity: normal → critical
Crash Signature: [@ mozilla::dom::DOMString::AsAString()]
Keywords: crash
Attachment #753063 - Attachment is obsolete: true
Comment on attachment 753116 [details] [diff] [review]
Bug 875169v1

Please just add overloads of GetSrclang and GetLabel that use nsString& as the outparam and get rid of the DOMString goop in this method altogether.
Attachment #753116 - Flags: review?(bzbarsky) → review-
Attached patch Patch version 2 (obsolete) — Splinter Review
- HTMLTrackElement() now has overloaded functions for GetLabel() and GetSrclang() that take nsString&
- HTMLTrackElement::CreateTextTrack() now uses these functions when creating a new TextTrack.
Attachment #753116 - Attachment is obsolete: true
Attachment #753592 - Flags: review?(bzbarsky)
Attachment #753592 - Flags: review?(bzbarsky)
Attached file Patch version 2 (obsolete) —
- HTMLTrackElement() now has overloaded functions for GetLabel() and GetSrclang() that take nsString&
- HTMLTrackElement::CreateTextTrack() now uses these functions when creating a new TextTrack.
Attachment #753592 - Attachment is obsolete: true
Attachment #753593 - Flags: review?(bzbarsky)
Attached patch Patch version 2Splinter Review
Wow... well this should be the right attachment. Sorry about that.
Attachment #753593 - Attachment is obsolete: true
Attachment #753593 - Flags: review?(bzbarsky)
Attachment #753594 - Flags: review?(bzbarsky)
Comment on attachment 753594 [details] [diff] [review]
Patch version 2

r=me.
Attachment #753594 - Flags: review?(bzbarsky) → review+
Blocks: 833386
New try push on top of incoming including the patches from bug 833382 and 881432.

https://tbpl.mozilla.org/?tree=Try&rev=81de1fc9d46c
I've starred most of the ones that I could find bugs on. The only one lest is the reftest crash on OS X.

I've spun up a build to test repeatability: https://tbpl.mozilla.org/?tree=Try&rev=5b34607a261b
Cipc failure from my try in comment #11 isn't repeatable, so looks like we're clean. Let me know when you're ready to land.
Looks good to me. Land ho!
https://hg.mozilla.org/mozilla-central/rev/fbab527d8a4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.