Closed
Bug 875183
Opened 11 years ago
Closed 11 years ago
Remove UA override for thechive.com
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g18+ fixed)
RESOLVED
FIXED
People
(Reporter: jsmith, Assigned: lmandel)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
fabrice
:
review+
bajaj
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #753949 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #753949 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 2•11 years ago
|
||
The advantage of dropping the UA override is the removal of an Android app add from the initial site launch.
tracking-b2g18:
--- → ?
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → lmandel
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 753949 [details] [diff] [review] Remove UA override for thechive.com [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A User impact if declined: thechive.com may advertise their Android app to Firefox OS users (they currently do) Testing completed: Tested on Unagi Risk to taking this patch (and alternatives if risky): Very low risk. The patch simply removes the one line UA override pref. String or UUID changes made by this patch: None.
Attachment #753949 -
Flags: approval-mozilla-b2g18?
Comment 4•11 years ago
|
||
John, can you assist with this checkin-needed request please?
Flags: needinfo?(jhford)
Comment 5•11 years ago
|
||
master: e8854c0a3b3ebba70448c9527bddddb789920d09
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jhford)
Keywords: checkin-needed
Resolution: --- → FIXED
Updated•11 years ago
|
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 753949 [details] [diff] [review] Remove UA override for thechive.com Looks like I made the wrong request for this patch. I should have requested approval-gaia-v1.
Attachment #753949 -
Flags: approval-mozilla-b2g18? → approval-gaia-v1?
Assignee | ||
Comment 7•11 years ago
|
||
John - Can you please help with the uplift to v1.1?
Flags: needinfo?(jhford)
Updated•11 years ago
|
Attachment #753949 -
Flags: approval-gaia-v1? → approval-gaia-v1+
You need to log in
before you can comment on or make changes to this bug.
Description
•