Ensure that UpdateTexture DispatchImageClientUpdate only dispatches if not in the ImageBridge thread

RESOLVED FIXED in mozilla24

Status

()

Core
Graphics: Layers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nical, Assigned: chiajung)

Tracking

23 Branch
mozilla24
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Dispatching this task is only a way to prevent IPDL methods to be called from outside the ImageBridge thread. It seems that we are calling it from within this thread, in which case we should not reschedule.
(Assignee)

Comment 1

4 years ago
Created attachment 753191 [details] [diff] [review]
Check the running thread before postTask

PostTask to the current running thread cause longer latency for real-time application like Camera. Just PostTask only when we are not running on the ImageBridge thread.
Attachment #753191 - Flags: review?(kchen)
Attachment #753191 - Flags: review?(kchen) → review+
(Reporter)

Comment 2

4 years ago
try push: https://tbpl.mozilla.org/?tree=Try&rev=05ada055f5d9
(Reporter)

Comment 3

4 years ago
Please add a well formatted commit header message in the patch before landing
(Assignee)

Comment 4

4 years ago
Created attachment 753547 [details] [diff] [review]
Add commit comment

Add commit comment before landing, carry r+
Attachment #753191 - Attachment is obsolete: true
Attachment #753547 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fbc7860ddbc
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1fbc7860ddbc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.