Last Comment Bug 875246 - Ensure that UpdateTexture DispatchImageClientUpdate only dispatches if not in the ImageBridge thread
: Ensure that UpdateTexture DispatchImageClientUpdate only dispatches if not in...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: 23 Branch
: x86_64 Linux
: -- normal (vote)
: mozilla24
Assigned To: Chiajung Hung [:chiajung]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-23 02:35 PDT by Nicolas Silva [:nical]
Modified: 2013-05-30 09:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Check the running thread before postTask (842 bytes, patch)
2013-05-23 02:43 PDT, Chiajung Hung [:chiajung]
kchen: review+
Details | Diff | Splinter Review
Add commit comment (1.09 KB, patch)
2013-05-23 16:56 PDT, Chiajung Hung [:chiajung]
ffantasy1999: review+
Details | Diff | Splinter Review

Description Nicolas Silva [:nical] 2013-05-23 02:35:03 PDT
Dispatching this task is only a way to prevent IPDL methods to be called from outside the ImageBridge thread. It seems that we are calling it from within this thread, in which case we should not reschedule.
Comment 1 Chiajung Hung [:chiajung] 2013-05-23 02:43:08 PDT
Created attachment 753191 [details] [diff] [review]
Check the running thread before postTask

PostTask to the current running thread cause longer latency for real-time application like Camera. Just PostTask only when we are not running on the ImageBridge thread.
Comment 2 Nicolas Silva [:nical] 2013-05-23 03:26:12 PDT
try push: https://tbpl.mozilla.org/?tree=Try&rev=05ada055f5d9
Comment 3 Nicolas Silva [:nical] 2013-05-23 03:28:07 PDT
Please add a well formatted commit header message in the patch before landing
Comment 4 Chiajung Hung [:chiajung] 2013-05-23 16:56:29 PDT
Created attachment 753547 [details] [diff] [review]
Add commit comment

Add commit comment before landing, carry r+
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-05-30 05:13:16 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fbc7860ddbc
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-05-30 09:02:32 PDT
https://hg.mozilla.org/mozilla-central/rev/1fbc7860ddbc

Note You need to log in before you can comment on or make changes to this bug.