875272 - Using trychooser to run tests on a subset of platforms does not work

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(no longer active)]

I used this trychooser string "try: -b d -p win32 -u mochitest-1[5.1,Windows XP,6.1,Windows 7] -t none" for this try push: <https://tbpl.mozilla.org/?tree=Try&rev=ce15d56c1902> and as you can see no mochitest-1 runs were scheduled.  This syntax is what http://trychooser.pub.build.mozilla.org/ produces.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

sfink, perhaps this is fallout from moving from 'WINNT x.y' to "Windows Z' style names ?

Comment 2

[Armen [:armenzg]]

10:37 sfink: two main quick options:
10:37 sfink: (1) switch the trychooser UI to use the new strings
10:38 sfink: (2) add in the old strings to just the prettyNames values (instead of or in addition to the new ones)
10:39 sfink: "proper" option: rewrite the communication between misc.py and try_parser.py to be a little more sensible, so we don't get into these messes
10:40 sfink: specifically, prettyNames doesn't need to be a magic string. It could be a full builder description object, and allow flexible matching on all kinds of different things without string parsing hacks.

Comment 3

[Steve Fink [:sfink] [:s:]]

Sadly, that's all wrong. Somebody already made the necessary update to the trychooser UI. Unfortunately, the try syntax parser does not allow spaces inside the options, because it's using a command-line parser. So

try: -b d -p win32 -u mochitest-1[5.1,Windows XP,6.1,Windows 7] -t none

parses as:

'-b': 'd'
'-p': 'win32'
'-u': 'mochitest-1[5.1,Windows'
'-t': none

and some extra junk that it ignores. :(

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Allows spaces within filter expressions

Comment 5

[Armen [:armenzg]]

https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

2013-05-23 12:12:53-0700 [-] Looking at changes: [<buildbot.changes.changes.Change instance at 0x24d98b48>]
2013-05-23 12:12:53-0700 [-] Found try message in the change comments, ignoring push comments
2013-05-23 12:12:53-0700 [-] TryChooser OPTIONS : MESSAGE Namespace(build=['opt'], talos=u'none', test=u'reftest[Windows 7]', user_platforms=set([u'win32'])) : try: -b o -p win32 -u reftest[Windows 7] -t none
2013-05-23 12:12:53-0700 [-] Adding request for {<buildbot.changes.changes.Change instance at 0x24d98b48>: ['WINNT 5.2 try build']}
2013-05-23 12:12:53-0700 [-] try-firefox: propfunc returned {'builduid': '66d70d383be446068a3ae06cb9edf0a6'}

Comment 6

[Armen [:armenzg]]

It did fix it.
ehsan, please let us know if you run into similar issues.

Comment 7

[(no longer active)]

(In reply to comment #6)
> It did fix it.
> ehsan, please let us know if you run into similar issues.

Will do, but this was the first time I used this feature -- I don't expect to use it that often.

That being said, I have been known to file bugs for anything broken that I encounter.  :-)