875282 - [MMS] The "Add Contact" button triggers the keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Mike Pennisi [:jugglinmike]]

Immediately after the "Add Contact" button is selected, the keyboard is needlessly displayed. Although it is dismissed once the associated "pick" Activity runs, the keyboard should not be displayed at all.

Comment 1

[Julien Wajsberg [:julienw]]

requesting leo? for this, even if this is polish, this is related to the Sms work, and this should be quite easy to fix (probably one or two lines).

Dietrich ?

Comment 2

[Mike Pennisi [:jugglinmike]]

Attachment: Do not give recipients focus when adding contacts

Hi Julien,

In Bug 874430, you suggested using `event.stopPropagation` in the handler for the "Add Contact" button. It turns out that we can fix the bug by addressing a more systemic issue:

The handler that gives focus to the recipients list (and subsequently triggers the keyboard) was delegating on an element that was too high in the DOM.

In addition to allowing future handlers to delegate on the click events to the "Add Recipient" button (for whatever reason), this approach addresses a somewhat surprising behavior in "master": clicking on the "max length" notice, the "convert" notice, or the carrier info would also give focus to the recipients list.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 753380 [details] [diff] [review]
Do not give recipients focus when adding contacts

Review of attachment 753380 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

seems to works perfect, thanks !

Comment 4

[Mike Pennisi [:jugglinmike]]

Landed at commit d0488a867fdc4e34f15c8ebbfcd0d424b3494a99

Thanks for reviewing, Julien

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: fe6c5ad

Comment 6

[Deepa Subramanian]

The user does not see the keyboard when "+" add contact button is tapped. Issue seems to be fixed.

Environmental Variables
Leo Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1