875297 - Move the contents of the initialize method into the constructor of the search-textbox binding

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 875042, we got rid of the setTimeout that was delaying the initialization of the search-toolbox. Gavin rightly pointed out that we could further simplify things if we just got rid of the initialize method and just dump all of its code directly into the constructor.

This is a super trivial piece of clean-up work, and an excellent first bug if somebody wants to get their feet wet in Firefox code.

Comment 1

[maofl]

Attachment: Patch for bug 875297

Put all code from the initialize method into the constructor, as suggested.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 757529 [details] [diff] [review]
Patch for bug 875297

Review of attachment 757529 [details] [diff] [review]:
-----------------------------------------------------------------

This is the right idea, but the indentation is a bit off. Take a look around the rest of the file - I think we're using 4 space indentation in there. Please conform to this.

Thanks!

Comment 3

[maofl]

Attachment: Patch for bug 875297 (replaces attachment 757529)

Now the identation should be correct (2 space identation).

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 758035 [details] [diff] [review]
Patch for bug 875297 (replaces attachment 757529 [details] [diff] [review])

Review of attachment 758035 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks Markus!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/950ab2f55a1a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/950ab2f55a1a