Closed Bug 875297 Opened 7 years ago Closed 7 years ago

Move the contents of the initialize method into the constructor of the search-textbox binding

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 24

People

(Reporter: mconley, Assigned: maofl)

References

Details

(Whiteboard: [good first bug][mentor=mconley][lang=xbl|js])

Attachments

(1 file, 1 obsolete file)

In bug 875042, we got rid of the setTimeout that was delaying the initialization of the search-toolbox. Gavin rightly pointed out that we could further simplify things if we just got rid of the initialize method and just dump all of its code directly into the constructor.

This is a super trivial piece of clean-up work, and an excellent first bug if somebody wants to get their feet wet in Firefox code.
Attached patch Patch for bug 875297 (obsolete) — Splinter Review
Put all code from the initialize method into the constructor, as suggested.
Attachment #757529 - Flags: review?(mconley)
Comment on attachment 757529 [details] [diff] [review]
Patch for bug 875297

Review of attachment 757529 [details] [diff] [review]:
-----------------------------------------------------------------

This is the right idea, but the indentation is a bit off. Take a look around the rest of the file - I think we're using 4 space indentation in there. Please conform to this.

Thanks!
Attachment #757529 - Flags: review?(mconley) → review-
Assignee: nobody → maofl
Status: NEW → ASSIGNED
Now the identation should be correct (2 space identation).
Attachment #757529 - Attachment is obsolete: true
Attachment #758035 - Flags: review?(mconley)
Comment on attachment 758035 [details] [diff] [review]
Patch for bug 875297 (replaces attachment 757529 [details] [diff] [review])

Review of attachment 758035 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks Markus!
Attachment #758035 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/950ab2f55a1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.