875301 - [MMS] Recipients should remain multiline if keyboard is closed (regardless of blur/focus)

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Attachment: Recipients hidden.

STR:
- Go to 'New message' panel
- Add 2 recipients
- Focus in input area for adding text
- Blur (tapping on grey area) for hiding the keyboard


EXPECTED: The app is working and you can see recipients as well.

CURRENTLY: Recipients are hidden, and layout is broken.

Comment 1

[Julien Wajsberg [:julienw]]

I wonder if that's not intended ?

You can swipe down the recipients panel to show it, I think that's what UX wanted.

Comment 2

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> I wonder if that's not intended ?
> 
> You can swipe down the recipients panel to show it, I think that's what UX
> wanted.

Nop, this is a bug. Users should not loose visibility of content of recipient modules in the 'to' field if the keyboard is closed.

Comment 3

[Rick Waldron [:rwaldron]]

Given the steps above, I cannot reproduce the issue. I will recap to confirm.

1. pull gaia/master
2. make clean; make install-gaia;
3. once device reboots, open Messaging app
4. tap "new" icon
5. type a letter, select a contact; repeat.
6. tap the "message" input field, cursor appears here.
7. tap the grey area, keyboard closes.

...Everything as expected. Then I tried this:


1. tap "new" icon
2. type a letter, select a contact; repeat.
3. tap the "message" input field, cursor appears here.
4. pull down recipients list, full list appears, cursor is still in the "message" input field
5. tap the grey area, keyboard closes, recipient list remains open.
6. tap the "message" input field again, cursor appears here and keyboard opens.


Again, everything works as expected.

Comment 4

[Noemí Freire (:noemi)]

Hi,

I can reproduce the issue as follows:

- Go to 'New message' panel
- Add 2 recipients not being stored in contacts, just typing the numbers: number #1+semicolon+number #2
- Focus in input area for adding text

Hope it helps

Comment 5

[Maria Angeles Oteo (:oteo)]

Hi,
it seems that (after talking with Julien) MMS development team is using gecko:b2g18 so using latest version of

gecko: b2g18
gaia: master
device: Unagi

I am not reproducing this bug with it.

Anyway, as Noemi has said, the fault is happening in master branch with gecko pointing to mozilla-central.

Comment 6

[Julien Wajsberg [:julienw]]

I reproduce this without a problem on my master/b2g18 build, so maybe there is a misunderstanding.

Here are the STR that I use :

* start a new message
* enter enough recipients to have a multi-lines recipient area
* tap in the grey zone

Expected:
* the keyboard closes, and the multiline recipient area is completely visible

Actual:
* the keyboard closes, the multiline recipient area is not completely visible

If I get it correctly, the multiline recipient area should be completely visible when the keyboard is off.

Comment 7

[Maria Angeles Oteo (:oteo)]

With b2g18 I don't experience the problem that Borja reported initially in this bug where the recipients are hidden (check attachment 753265 [details]) but I do in gecko mozilla central.

Anyway I am seeing in b2g18 the bug that Julien is reporting in comment 6 (perhaps you should file a new bug for it as it's different than the one reported by Borja) and the multirecipient area is not completely visible.

requesting info to Ayman and Victoria

Comment 8

[Julien Wajsberg [:julienw]]

I haven't checked borja's screenshot prior commenting (by bad !), it looks like a different bug indeed. We can bugmorph (change the title ;) ) this one if the original bug is fixed though :)

Comment 9

[Maria Angeles Oteo (:oteo)]

(In reply to Julien Wajsberg [:julienw] from comment #8)
> I haven't checked borja's screenshot prior commenting (by bad !), it looks
> like a different bug indeed. We can bugmorph (change the title ;) ) this one
> if the original bug is fixed though :)
yeah, no problem ;)

Anyway, for the new bug you have commented, if you pull down the multi-recipients area you can see all the recipients, I think it's enough as the input and the grey area are the most important ones.

Anyway, Ayman can confirm us this behaviour before creating more bugs ;)

Comment 10

[Julien Wajsberg [:julienw]]

Yep that was the meaning of my comment 1, but with Ayman's comment 2 I don't know anymore ;)

Comment 11

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #6)
> I reproduce this without a problem on my master/b2g18 build, so maybe there
> is a misunderstanding.
> 
> Here are the STR that I use :
> 
> * start a new message
> * enter enough recipients to have a multi-lines recipient area
> * tap in the grey zone
> 
> Expected:
> * the keyboard closes, and the multiline recipient area is completely visible
> 
> Actual:
> * the keyboard closes, the multiline recipient area is not completely visible
> 
> If I get it correctly, the multiline recipient area should be completely
> visible when the keyboard is off.

Hi Julien

Tapping on the grey zone should not make the multi-recipient area completely visible because this could create peculiar behavior if there is so much content in the message text box (living between the attach CTA and send CTA)  that it has expanded. 

so path should be:

1) start a new message
2) enter enough recipients to have a multi-lines recipient area
3) tap in the grey zone

Expected:
the keyboard closes

Pulling down on the 'To' area to reveal the full list of contents should suffice. I am happy to discuss this further if you wish

Comment 12

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #10)
> Yep that was the meaning of my comment 1, but with Ayman's comment 2 I don't
> know anymore ;)

With comment 2 i was referring specifically to the attachment Borja submitted where the modules in the to field seem to loose their content when the keyboard closes... that really not desirable ;)

Comment 13

[Rick Waldron [:rwaldron]]

(In reply to ayman maat :maat from comment #11)

> 
> Pulling down on the 'To' area to reveal the full list of contents should
> suffice. I am happy to discuss this further if you wish


Note "the full list of contents" is a scrollable area.


As for the original issue, per the attachment, I cannot reproduce this

gecko: b2g18
gaia: master
device: Unagi

Comment 14

[Julien Wajsberg [:julienw]]

me neither, never saw this and I use this every day.

Thanks all !