875397 - First new window created after leaving fullscreen mode has wrong size (it's always maximized)

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect, P2)

Description

[Mario Grgic]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:

1. Launch Firefox
2. Enter full screen (Mac OS X Mountain Lion) by pressing arrows icon in the top right corner or keyboard shortcut. 
3. Exit full screen
4a. Immediately press CMD+n to open new Firefox window. 
4b Exit Firefox


Actual results:

The newly opened Firefox window will be maximized. If you close this maximized second window, and immediately open new window again with CMD+n, next window will be the same size as original, which is what should have happened in step 4a above. 

This is in fact worse. If instead of 4a you did 4b, next time you launch Firefox its main window will be maximized and information about your preferred window size is lost.


Expected results:

The original Firefox main window size should have not been changed when entering/exiting full screen, even if the user quit/closed Firefox in full screen mode the full screen size should never ever be saved as preferred size (because there is an explicit gesture to enter this size from any other window size).

Comment 1

[Steven Michaud [:smichaud] (Retired)]

This sounds like a dup of bug 752294 (the part that hasn't yet been fixed).

To my mind, if you quit Firefox while it has a single window open in fullscreen mode, the next time you run Firefox it should open a single window in fullscreen mode.

But this is easier said than done (see particularly bug 752294 comment #5).  So it'll be a while before we can accomplish it.

Comment 2

[Mario Grgic]

Native OS X applications do not behave that way with respect to full screen mode. If you enter full screen in say preview (viewing a PDF or image) and quit, next time you launch preview it will not open in full screen. 

But this is also not the main focus of this bug report. The main problem with Firefox is that even if you exit full screen and quit, it will still launch in full screen next time and forget your preferred browser window size and location on screen.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

I've played with this a bit more, and now understand it better.  Here's a better description, and better STR.

1) Run Firefox on Lion or Mountain Lion.
2) Enter full screen (using either the fullscreen button or Cmd-Shift-f).
3) Exit full screen (using either the fullscreen button or Cmd-Shift-f).
4) Open a new window (using either File : New Window or Cmd-n).
   It will be maximized, which is incorrect.
5) Close the new window.
6) Open another new window.
   It will be the correct size (the same size as the window in step 1).

My guess is that the size settings for the original window (from step 1) get messed up when you transition to and away from fullscreen mode.

Comment 5

[Qualmitill82]

I have this problem too. Only I'm using Linux and Gnome. Firefox ignores correct window size and puts "height":"1059" into 'main-window' section of the `xulstore.json`. The correct value is 1920, and I have absolutely no idea where this strange value comes from. Probably it's randomly generated.

Comment 6

[Tracy Walker [:tracy]]

On Mac 10.11, with latest Nightly 49.0a1, 20160518030234

I can reproduce with Stephen's STR's in comment #3.

Comment 7

[Scott Macpherson]

Can anyone replicate this in a recent version? I can't seem to reproduce this using 54.0a2 on macOS 10.12.4.

Comment 8

[Josh Aas]

I can't reproduce this on 10.12.5 and Firefox 54.0.1.