875398 - Defect - Metro firefox Form history auto-complete spews DEPRECATION WARNING messages since the landing of bug 697377

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect, P1)

Description

[Jim Mathies [:jimm]]

[JavaScript Error: "DEPRECATION WARNING: nsIFormAutoComplete::autoCompleteSearch is deprecated
You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=697377
file:///T:/Mozilla/MC-REL/dist/bin/components/nsFormAutoComplete.js 119 FormAutoComplete.prototype.autoCompleteSearch
file:///T:/Mozilla/MC-REL/dist/bin/metro/components/FormAutoComplete.js 77 autoCompleteSearch
chrome://browser/content/helperui/FormHelperUI.js 193 _formHelperGetAutocompleteSuggestions
chrome://browser/content/helperui/FormHelperUI.js 175 _formHelperUpdateSuggestionsFor
chrome://browser/content/helperui/FormHelperUI.js 166 _formHelperUpdatePopupsFor
chrome://browser/content/helperui/FormHelperUI.js 75 formHelperShow
chrome://browser/content/helperui/FormHelperUI.js 112 _onShowRequest
chrome://browser/content/helperui/FormHelperUI.js 147 formHelperReceiveMessage
null 0 null
" {file: "resource://gre/modules/Deprecated.jsm" line: 79}]

Comment 1

[Jim Mathies [:jimm]]

Simple work around until this is fixed is to comment out the offending line of code in toolkit - 

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/nsFormAutoComplete.js#119

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 3

[Jim Mathies [:jimm]]

I've pulled the new code from android, which is more up to date. Also, for some reason fennec had a wrapper around the form auto complete service which added special handling for html5 inputs. The android code doesn't use this anymore, so I'm guessing the service has been updated to deal with tese input types. So I've removed the wrapper.

I'm also going to write a few simple tests for this.

Comment 4

[Jim Mathies [:jimm]]

Attachment: auto-complete updates v.1

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 754833 [details] [diff] [review]
auto-complete updates v.1

This patch updates our form auto-complete code so that it matches android's current version. It also removed an old html5 contact info skimmer we don't use.

Comment 6

[Jim Mathies [:jimm]]

Attachment: tests

Add a really basic form fill test so if this breaks in the future we know about it.

Comment 7

[Brian R. Bondy [:bbondy]]

Comment on attachment 754833 [details] [diff] [review]
auto-complete updates v.1

Review of attachment 754833 [details] [diff] [review]:
-----------------------------------------------------------------

As per discussion on irc, this changes the behavior of autocomplete so that when you have a partial match and no autococmplete open, a tap or double click does not open autocomplete with the matched entries. I think it should show those entries in that case to be consistent with desktop firefox.

Comment 8

[Brian R. Bondy [:bbondy]]

By the way if you feel like it, it would also be nice for the autocomplete to come up as you type like it does for Desktop firefox.

Comment 9

[Jim Mathies [:jimm]]

Attachment: auto-complete updates v.2

This gets both scenarios working. The only change was the removal of the block of android specific code at line 176 of the original patch.

Comment 10

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37fdc59d6b60
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9769ac5701

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/37fdc59d6b60
https://hg.mozilla.org/mozilla-central/rev/cf9769ac5701