875418 - test infrastructure is probably not quite right for non-ES tests

Status: RESOLVED FIXED

(support.mozilla.org :: Code Quality, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tests that use ESTestCase are probably fine. The ESTestCase sets things up correctly so that the test uses ES, runs against the correct ES server and all the things work right.

However, tests that don't use ESTestCase end up with the wrong READ_INDEX and WRITE_INDEX values. Further, it's not clear that setting ES_LIVE_INDEXING to False actually shuts ES functionality off.

Therefore it's possible tests that aren't using ESTestCase could be suffering a performance hit if they execute code that expects ES to be there and more importantly, they may be doing things we don't want them doing.

This bug covers looking into that and doing whatever is needed to alleviate the problem. That might include mocking something in the ES-related layers, fixing the settings values or related things.


(If this sounds hand-wavey, kick Will.)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tossing this in the backlog.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Putting into the next sprint. Willkg suspects this is a 2pt bug.

Comment 3

[Michael Cooper [:mythmon]]

I'll see if I can figure something out here.

Comment 4

[Michael Cooper [:mythmon]]

PR: https://github.com/mozilla/kitsune/pull/1568

Comment 5

[Michael Cooper [:mythmon]]

Landed in 6a332fb189ec452f823da9586232e192c2296688. This is a problem with the tests, not the site, so this is done.