Rename ListBase to DOMProxy

RESOLVED FIXED in mozilla24

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bz, Assigned: Anand Soni)

Tracking

unspecified
mozilla24
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bz][lang=C++])

Attachments

(1 attachment, 3 obsolete attachments)

ListBase is totally a misnomer at this point.  We should just call it DOMProxy, I think.
Is this bug simply about renaming all the occurences of ListBase to DOMProxy (https://mxr.mozilla.org/mozilla-central/search?string=ListBase&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central) or is there something more to it too ?
I think that's about all there is to it, if you ignore the mobile/ hits in mxr there.
(Assignee)

Comment 3

4 years ago
Hi Boris,

I would like to help fixing this bug. Can you brief me on the procedure? I have no knowledge on submitting patches to mozilla.

Thanks!
Check out https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch and https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F . You can also join #introduction on irc.mozilla.org if you want to ask questions.

As far as this bug is concerned, I guess you simply need to rename all the occurences of ListBase to DOMProxy (https://mxr.mozilla.org/mozilla-central/search?string=ListBase&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central) except the ones in the files inside mobile/ directory, as pointed out by bz in https://bugzilla.mozilla.org/show_bug.cgi?id=875449#c2.
Yep, comment 4 about covers it.  ;)
(Assignee)

Comment 6

4 years ago
Thank you for the pointers. I have set up mercurial and cloned the repository. I will soon submit a patch for review.

Thanks a lot!
(Assignee)

Comment 7

4 years ago
Do I need to change only ListBase to DOMProxy or listBase also?
Yeah, it's probably a good idea to change the variable names to reflect the class name.  There will be a number of different variants of these.  There are also method names that have "ListBase" in the name (e.g. IsCacheableListBaseProxy) in ion/IonCache.cpp.

It's good to change all of those to have new names to match the new "DOMProxy" naming scheme.

e.g. the listBase variable names would become domProxy, IsCacheableListBaseProxy would become IsCacheableDOMProxy, etc.
(Assignee)

Comment 9

4 years ago
Ok. I got it. 
Now, ListBase will become DOMProxy for each occurence and, listBase will become domProxy for each occurence.
(Assignee)

Comment 10

4 years ago
What flags should I request (for review and others below it) while attaching the patch?
I suggest requesting review from and :djvj.
(Assignee)

Comment 12

4 years ago
Created attachment 758364 [details] [diff] [review]
Fix for bug 875449. Attaching the first patch for review.
Attachment #758364 - Flags: review+
Comment on attachment 758364 [details] [diff] [review]
Fix for bug 875449. Attaching the first patch for review.

When you ask for review, put a r? flag against the attachment, and in this case set the requestee as :djvj.
Attachment #758364 - Flags: review+ → review?(kvijayan)
(Assignee)

Comment 14

4 years ago
Thank you for the correction sankha93. I was not aware of this.
(Assignee)

Comment 15

4 years ago
Hi :djvj,

Is the patch correct? Do I need to modify/change it or add something? Please let me know.
Sorry, got caught up by some other bugs.  Reviewing this now.
Comment on attachment 758364 [details] [diff] [review]
Fix for bug 875449. Attaching the first patch for review.

Review of attachment 758364 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Nice job :)  Just fix the minor issue with the comment and you're good to go.

::: js/src/ion/BaselineIC.h
@@ +4196,4 @@
>  {
>    friend class ICStubSpace;
>    protected:
> +    // Shape of the DOMProxy proxy

Remove 'proxy' here.  "// Shape of the DOMProxy" should be fine.
Attachment #758364 - Flags: review?(kvijayan) → review+
DOMListShadows should probably become DOMProxyShadows too.
(Assignee)

Comment 19

4 years ago
Created attachment 759282 [details] [diff] [review]
Modified fix for Bug 875449 with the comment changed.
Attachment #759282 - Flags: review?(kvijayan)
(Assignee)

Comment 20

4 years ago
Fix on the comment by :djvj. I will change the occurence of DOMListShadow to DOMProxyShadow in the following files now:
https://mxr.mozilla.org/mozilla-central/search?string=DOMListShadow&case=1&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-central

Will that be it?
(Assignee)

Comment 21

4 years ago
Also, the bug has not been assigned to me yet. :)
You also want a sane commit comment.  ;)
Assignee: general → anand.92.soni
(Assignee)

Comment 23

4 years ago
Created attachment 759305 [details] [diff] [review]
Final attachment with all the required and suggested changes.
Attachment #759305 - Flags: review?(kvijayan)
(Assignee)

Comment 24

4 years ago
Hi :bz and :djvj,
I think I have made the suggested changes. Please review again.
(In reply to Anand Soni from comment #23)
> Created attachment 759305 [details] [diff] [review]
> Final attachment with all the required and suggested changes.

For future reference:

If you're just making minor changes, and addressing comments, you don't have to ask for a re-review.  You can use the previous r+.

If I felt that the requested changes needed a re-review, I would have canceled or r-ed the review.

I'd say you can go ahead and cancel the review request and just commit.
(Assignee)

Comment 26

4 years ago
What does that mean? I mean, what should I do exactly? Should I change it to r+?
To cancel a review request, just click on the "Details" link for the patch, and change the flag associated with "Review" to the blank option (available on the pulldown).  It'll remove the review request.
Comment on attachment 759305 [details] [diff] [review]
Final attachment with all the required and suggested changes.

How about this for the commit message:

Bug 875449: rename ListBase to DOMProxy, since these proxies are used for all sorts of objects that aren't in any way like lists.  r=djvj

?
(Assignee)

Updated

4 years ago
Attachment #759305 - Flags: review?(kvijayan)
(Assignee)

Comment 29

4 years ago
Created attachment 759319 [details] [diff] [review]
Final attachment with all the required and suggested changes.
(Assignee)

Comment 30

4 years ago
:bz and :djvj, is everything good now?
(Assignee)

Comment 31

4 years ago
What is the next step?
(Assignee)

Comment 32

4 years ago
:djvj and :bz,

Will you push it in the tree for me? I donot have the access.
The next step is to mark all the obsolete stuff as obsolete so it's clear what needs to be checked in and then adding the "checkin-needed" keyword.  ;)

That way anyone who checks for those will push it if djvj and I don't get around to pushing things soon enough.
Keywords: checkin-needed
Attachment #758364 - Attachment is obsolete: true
Attachment #759282 - Attachment is obsolete: true
Attachment #759282 - Flags: review?(kvijayan)
Attachment #759305 - Attachment is obsolete: true
(Assignee)

Comment 34

4 years ago
Thank you Boris! I hope this gets checked-in soon. Do we need to change the status of this bug?
No, you can now relax! You have fixed your first bug. :)

The person who will check in, will update the status of the bug.
(Assignee)

Comment 36

4 years ago
Alright. I got it now. Thank you Sankha!
https://hg.mozilla.org/integration/mozilla-inbound/rev/0261df8a6a8e

Thanks for the patch, Anand!
Keywords: checkin-needed
And a bustage follow-up.
https://hg.mozilla.org/integration/mozilla-inbound/rev/166c6df896ba
(Assignee)

Comment 39

4 years ago
Hi RyanVM,

I suppose this means that the patch will be further tested and then pushed to mozilla-central. And then this bug will be closed (tagged as resolved). Is that so?
Yes, exactly :)
(Assignee)

Comment 41

4 years ago
Alright, thanks a lot! 
Can I know something about the mozilla try server and can I have a level 1 commit access to it now? Please let me know.
If you want to request Level 1 commit access, you can follow the directions below.
http://www.mozilla.org/hacking/commit-access-policy/

I'd say there are plenty of people involved in this bug who can give you a vouch.
(Assignee)

Comment 43

4 years ago
Thank you RyanVM for the guidance!

bz, djvj, sankha93.. can anyone vouch for me? I am filing a bug for level-1 access to the try server.
https://hg.mozilla.org/mozilla-central/rev/0261df8a6a8e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
And because I'm an idiot who merged bustage over to m-c...
https://hg.mozilla.org/mozilla-central/rev/6cafe68983ca
(Assignee)

Comment 46

4 years ago
Finally resolved! :)
You need to log in before you can comment on or make changes to this bug.