Closed Bug 875490 Opened 12 years ago Closed 12 years ago

make aws stop idle more intelligent about buildbot master http port

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(4 files)

Right now it looks for pbport - 1000, which isn't working well for servo now that we've got a rw and ro WebStatus. It should probably look at production-masters.json instead... Attached is a patch to add the servo master...does it make sense to do that, since it's a completely different master?
Attachment #753467 - Flags: feedback?(rail)
Attachment #753467 - Flags: feedback?(catlee)
Comment on attachment 753467 [details] [diff] [review] servo in production-masters.json I think this is not a bad idea, since we manage the masters.
Attachment #753467 - Flags: feedback?(rail) → feedback+
Tested this with both a file + http link. Works fine as long you don't use SSL. I won't wait for Catlee's opinion on the production masters patch before landing, but I'd still like it after the fact. If we decide we should keep the masters separate, I can modify this patch to support multiple production masters files.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #755552 - Flags: review?(rail)
Attachment #755552 - Flags: review?(rail) → review+
Attachment #753467 - Flags: checked-in+
Comment on attachment 755552 [details] [diff] [review] lookup http port in production masters Updated cruncher's local repo, too.
Attachment #755552 - Flags: checked-in+
Comment on attachment 753467 [details] [diff] [review] servo in production-masters.json Backed this out because it broke setup-masters.py --test, and there was no clear fix: + ./test-masters.sh Traceback (most recent call last): File "./setup-master.py", line 343, in <module> dedupe=dedupe) File "./setup-master.py", line 231, in load_masters_json raise AssertionError("What is a %s role?" % m['role']) AssertionError: What is a servo role?
Attachment #753467 - Flags: checked-in+ → checked-in-
Doesn't really block...I've been shutting things down by hand for now.
No longer blocks: 861283
Comment on attachment 753467 [details] [diff] [review] servo in production-masters.json looks ok for starters. if we get to the point of needing split masters for servo (or other projects), we may want to split this file up.
Attachment #753467 - Flags: feedback?(catlee) → feedback+
Best solution I could come up with to solve the setup-master.py problem. It has the added bonus of removing a hack related to universal master testing.
Attachment #757898 - Flags: review?(rail)
Same thing for manage masters.
Attachment #757899 - Flags: review?(rail)
Attachment #757898 - Flags: review?(rail) → review+
Attachment #757899 - Flags: review?(rail) → review+
Attachment #757898 - Flags: checked-in+
Attachment #757899 - Flags: checked-in+
Comment on attachment 753467 [details] [diff] [review] servo in production-masters.json Trying again...
Attachment #753467 - Flags: checked-in- → checked-in+
This worked: 2013-06-04 07:11:05,516 - servo-linux64 - stopped 1 2013-06-04 07:11:05,516 - tst-linux32 - stopped 16
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Live in production.
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: