Closed
Bug 875490
Opened 12 years ago
Closed 12 years ago
make aws stop idle more intelligent about buildbot master http port
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(4 files)
|
1.07 KB,
patch
|
catlee
:
feedback+
rail
:
feedback+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
5.60 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
2.59 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
1.48 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Right now it looks for pbport - 1000, which isn't working well for servo now that we've got a rw and ro WebStatus. It should probably look at production-masters.json instead...
Attached is a patch to add the servo master...does it make sense to do that, since it's a completely different master?
Attachment #753467 -
Flags: feedback?(rail)
Attachment #753467 -
Flags: feedback?(catlee)
Comment 1•12 years ago
|
||
Comment on attachment 753467 [details] [diff] [review]
servo in production-masters.json
I think this is not a bad idea, since we manage the masters.
Attachment #753467 -
Flags: feedback?(rail) → feedback+
| Assignee | ||
Comment 2•12 years ago
|
||
Tested this with both a file + http link. Works fine as long you don't use SSL. I won't wait for Catlee's opinion on the production masters patch before landing, but I'd still like it after the fact. If we decide we should keep the masters separate, I can modify this patch to support multiple production masters files.
Updated•12 years ago
|
Attachment #755552 -
Flags: review?(rail) → review+
| Assignee | ||
Updated•12 years ago
|
Attachment #753467 -
Flags: checked-in+
| Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 755552 [details] [diff] [review]
lookup http port in production masters
Updated cruncher's local repo, too.
Attachment #755552 -
Flags: checked-in+
| Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 753467 [details] [diff] [review]
servo in production-masters.json
Backed this out because it broke setup-masters.py --test, and there was no clear fix:
+ ./test-masters.sh
Traceback (most recent call last):
File "./setup-master.py", line 343, in <module>
dedupe=dedupe)
File "./setup-master.py", line 231, in load_masters_json
raise AssertionError("What is a %s role?" % m['role'])
AssertionError: What is a servo role?
Attachment #753467 -
Flags: checked-in+ → checked-in-
| Assignee | ||
Comment 5•12 years ago
|
||
Doesn't really block...I've been shutting things down by hand for now.
No longer blocks: 861283
Comment 6•12 years ago
|
||
Comment on attachment 753467 [details] [diff] [review]
servo in production-masters.json
looks ok for starters. if we get to the point of needing split masters for servo (or other projects), we may want to split this file up.
Attachment #753467 -
Flags: feedback?(catlee) → feedback+
| Assignee | ||
Comment 7•12 years ago
|
||
Best solution I could come up with to solve the setup-master.py problem. It has the added bonus of removing a hack related to universal master testing.
Attachment #757898 -
Flags: review?(rail)
| Assignee | ||
Comment 8•12 years ago
|
||
Same thing for manage masters.
Attachment #757899 -
Flags: review?(rail)
Updated•12 years ago
|
Attachment #757898 -
Flags: review?(rail) → review+
Updated•12 years ago
|
Attachment #757899 -
Flags: review?(rail) → review+
| Assignee | ||
Updated•12 years ago
|
Attachment #757898 -
Flags: checked-in+
| Assignee | ||
Updated•12 years ago
|
Attachment #757899 -
Flags: checked-in+
| Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 753467 [details] [diff] [review]
servo in production-masters.json
Trying again...
Attachment #753467 -
Flags: checked-in- → checked-in+
| Assignee | ||
Comment 10•12 years ago
|
||
This worked:
2013-06-04 07:11:05,516 - servo-linux64 - stopped 1
2013-06-04 07:11:05,516 - tst-linux32 - stopped 16
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 11•12 years ago
|
||
Live in production.
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•