875732 - Need hooks for new column in saved-searches

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[rojanu]

saved-searches needs hooks to provide a way for extensions to insert new columns


E.g. MyDashboard on bmo uses two hooks to insert a column. These hooks could be moved to mainstream bugzilla code

Comment 1

[rojanu]

Attachment: saved-header/row hooks

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 753738 [details] [diff] [review]
saved-header/row hooks

Review of attachment 753738 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl. We have this change in our BMO code to support the MyDashboard extension so I know it works fine.

Comment 3

[Frédéric Buclin]

Comment on attachment 753738 [details] [diff] [review]
saved-header/row hooks

This is mostly good, but you must also fix the first row for "My Bugs". You cannot add anything to it, and the number of cells is then inaccurate for this row. You can reuse the hook name 'saved-row'.

Also, please attach a working patch:

patch -p0 --dry-run < ~/patches/bug875732.diff 
(Stripping trailing CRs from patch.)
patching file template/en/default/account/prefs/saved-searches.html.tmpl
patch unexpectedly ends in middle of line

That's because your patch lacks a final newline at the end of the file.

Comment 4

[rojanu]

Attachment: saved-searches-saved-row.patch

Added the hook to the top row as well and corrected the patch file ending

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 779358 [details] [diff] [review]
saved-searches-saved-row.patch

r=dkl

Comment 6

[Simon Green]

Comment on attachment 779358 [details] [diff] [review]
saved-searches-saved-row.patch

r- on the basis that extensions/Example/template/en/default/account/prefs/ is not updated with an example.

Comment 7

[Frédéric Buclin]

(In reply to Simon Green from comment #6)
> r- on the basis that extensions/Example/template/en/default/account/prefs/
> is not updated with an example.

Template hooks do not need an example to be accepted. Only code hooks must be documented and have an example.

Comment 8

[David Lawrence [:dkl]]

Thanks for the patch.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified template/en/default/account/prefs/saved-searches.html.tmpl
Committed revision 8692.  

dkl