875826 - various xpcshell tests in toolkit/identity/... fail on Android

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Geoff Brown [:gbrown]]

I am trying to run more xpcshell tests on Android. 

Most of the toolkit/identity tests fail.

See logs at https://tbpl.mozilla.org/php/getParsedLog.php?id=23349075&tree=Try&full=1

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Hi, Geoff,
I'll take a look

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Remove obsolete identity files and tests

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

https://tbpl.mozilla.org/?tree=Try&rev=6d361a81d456

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

This patch leaves browser/modules/SignInToWebsite.jsm hanging in a broken state, and unused ux in the browser xul code.  However, for Bug 973906, we already completely disabled that module anyway, so as not to entangle it with rapid b2g changes.  So this does not in fact change the status quo.

I'm suggesting we land this patch here, rather than as part of bug 845546, so that we can unblock testing first and then not be rushed in evaluating the patches for bug 845546.

Comment 5

[Matthew N. [:MattN]]

Attachment: v.1 Skip xpcshell tests that require the identity components

Skip xpcshell tests that require the identity components on Android since they're not packaged there.

I don't think we should remove the code and tests until there is a replacement and that's already being addressed in bug 845546.

Try push with no identity failures: https://tbpl.mozilla.org/?tree=Try&rev=955a609c9466

Comment 6

[Matthew N. [:MattN]]

Thanks. 
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/d030698ee3e8
Try push: https://tbpl.mozilla.org/?tree=Try&rev=7ddc5697c126

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d030698ee3e8