Closed Bug 875865 Opened 8 years ago Closed 8 years ago

Splinter doesn't parse patches where the hunk is missing the source range length

Categories

(bugzilla.mozilla.org :: Splinter, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ahal, Assigned: glob)

Details

See: https://bug790765.bugzilla.mozilla.org/attachment.cgi?id=753879

Notice how manifest.ini has some lines added. When opening this patch in splinter, manifest.ini appears to be empty.
Assignee: nobody → glob
ah, it's probably confused by the "no newline" marker.
nope, it has an invalid hunk range:
> @@ -1 +1,5 @@

normally only the trailing length value is optional, so this should be written as:
> @@ -1,1 +1,5 @@

regardless, fixed:

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Splinter/web/splinter.js
Committed revision 8821.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Summary: Splinter doesn't parse attachment 753879 properly → Splinter doesn't parse patches where the hunk is missing the source range length
You need to log in before you can comment on or make changes to this bug.