876030 - Defect - The tile selection app bar should disappear if the user navigates to a page

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P1)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

STR:
  1) Open a tab
  2) Select one or multiple tiles
  3) Note that the tile context app bar has appeared
  4) Tap a tile to navigate to that page
  5) Note that the tile context app bar is still visible, even though it no longer makes sense

Comment 2

[Brian R. Bondy [:bbondy]]

p=1

Comment 3

[Jim Mathies [:jimm]]

Attachment: rename 'appbar' to 'navbar'

This was really confusing at first glance since we now have two app bars, the nav bar and the context app bar. So I renamed 'appbar' to 'navbar' to clear up the confusion.

Comment 4

[Jim Mathies [:jimm]]

Attachment: bug fix

The bug fix.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 755417 [details] [diff] [review]
bug fix

Review of attachment 755417 [details] [diff] [review]:
-----------------------------------------------------------------

Yep

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 755416 [details] [diff] [review]
rename 'appbar' to 'navbar'

Review of attachment 755416 [details] [diff] [review]:
-----------------------------------------------------------------

The ContentAreaObserver patch looks fine but needs some changes from the parent bug to apply. All else works, clean test run. Thanks for clearing this up it was a source of ongoing confusion.

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a14649f8410c
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f0f28089ee0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a14649f8410c
https://hg.mozilla.org/mozilla-central/rev/0f0f28089ee0

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20130610 Firefox/24.0

Verified the fix on latest Nightly build: the context appbar is successfully dismissed when a page is loaded.

Comment 10

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.