Closed
Bug 876037
Opened 12 years ago
Closed 12 years ago
make app.releaseNotesURL and app.vendorURL optional
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: Gavin, Assigned: raymondlee)
Details
Attachments
(1 file, 2 obsolete files)
|
6.88 KB,
patch
|
Details | Diff | Splinter Review |
These are only used in about:, which isn't really exposed. To reduce the amount of prefs we need to set in Firefox, I'd like to just remove them there.
|
Assignee | |
Comment 1•12 years ago
|
||
id=vendorURL already points to http://www.mozilla.org/ in about:. Is it ok for id="releaseNotesURL" points to http://www.mozilla.org/en-US/firefox/releases/ by default?
Attachment #754404 -
Flags: review?(gavin.sharp)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 754404 [details] [diff] [review]
v1
I think we should remove the links (both vendorURL and releasenotes) when the pref doesn't exist.
Attachment #754404 -
Flags: review?(gavin.sharp) → feedback+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Hide the release note element by default and show it if a pref exists.
Removed the href on the anchor tag for vendorURL so it doesn't look like a link.
Assignee: nobody → raymond
Attachment #754404 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #756128 -
Flags: review?(gavin.sharp)
|
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 756128 [details] [diff] [review]
v2
thanks!
Attachment #756128 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #756128 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•