876037 - make app.releaseNotesURL and app.vendorURL optional

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

These are only used in about:, which isn't really exposed. To reduce the amount of prefs we need to set in Firefox, I'd like to just remove them there.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

id=vendorURL already points to http://www.mozilla.org/ in about:.  Is it ok for id="releaseNotesURL" points to http://www.mozilla.org/en-US/firefox/releases/ by default?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 754404 [details] [diff] [review]
v1

I think we should remove the links (both vendorURL and releasenotes) when the pref doesn't exist.

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v2

Hide the release note element by default and show it if a pref exists.

Removed the href on the anchor tag for vendorURL so it doesn't look like a link.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 756128 [details] [diff] [review]
v2

thanks!

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/cypress/rev/1b236820d6ae

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b236820d6ae