Closed
Bug 876060
Opened 12 years ago
Closed 12 years ago
Medium tap on link does not follow the link
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox22 affected, firefox23 affected, firefox24 verified)
VERIFIED
FIXED
Firefox 24
People
(Reporter: jruderman, Assigned: kats)
References
Details
(Whiteboard: [testday-20130726])
Attachments
(1 file)
2.93 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
Using Firefox Beta 22 on Android 4.2.2 on a Samsung Galaxy Nexus:
1. Hold down a link for half a second (long enough to be sure I tapped the right thing, but not long enough to bring up a menu)
Result: The link background becomes gray, but Firefox does not follow the link.
Expected: Firefox should follow the link.
Comment 1•12 years ago
|
||
This works for me, links are followed through every time.
Reporter | ||
Comment 2•12 years ago
|
||
Odd, I can reproduce this almost reliably.
Assignee | ||
Comment 3•12 years ago
|
||
Do you see this on Nightly too? If so I can can create a custom build with some debug logging to isolate the issue.
Also is there a specific page/link you can point to with this problem?
Reporter | ||
Comment 4•12 years ago
|
||
I see this on Nightly too.
This happens on most pages, including:
* Links at the bottom of http://nightly.mozilla.org/
* Links at the bottom of http://www.squarefree.com/start/
![]() |
||
Comment 5•12 years ago
|
||
I think I know what Jesse means here, 3 possible scenarios:
1. Hold down the link for a very short time
-> tap on link, link follows through.
2. Hold down the link for not a very short time but short enough to *not* trigger the menu
-> word gets highlighted.
3. Hold down the link for a longer time than scenario 2.
-> menu comes up.
Jesse should be hitting the 2nd scenario.
Comment 6•12 years ago
|
||
I saw this today too on Nightly (05/29); HTC One (Android 4.1.2)
Assignee | ||
Comment 7•12 years ago
|
||
Assignee: nobody → bugmail.mozilla
Attachment #755951 -
Flags: review?(chrislord.net)
Comment 8•12 years ago
|
||
Are you sure this doesn't send taps if you tap and pan?
Assignee | ||
Comment 9•12 years ago
|
||
Yeah if you pan you don't get the onSingleTapUp call.
Comment 10•12 years ago
|
||
Comment on attachment 755951 [details] [diff] [review]
Treat medium-length taps as clicks
Review of attachment 755951 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine, couple of nits.
::: mobile/android/base/gfx/JavaPanZoomController.java
@@ +1233,5 @@
>
> GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent(event, json));
> }
>
> + @Override public boolean onDown(MotionEvent motionEvent) {
Don't we usually put @Override on a separate line?
@@ +1238,5 @@
> + mMediumPress = false;
> + return false;
> + }
> +
> + @Override public void onShowPress(MotionEvent motionEvent) {
ditto.
@@ +1243,5 @@
> + // If we get this, it will be followed either by a call to
> + // onSingleTapUp (if the user lifts their finger before the
> + // long-press timeout) or a call to onLongPress (if the user
> + // does not). In the former case, we want to make sure it is
> + // treated as a click.
So I assume that after this, a double-tap won't be recorded? If so, I think this should be added to the comment here. The comment below alludes to this, but I think it could be clearer.
Attachment #755951 -
Flags: review?(chrislord.net) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Addressed all comments above and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a18e65a667e1
Comment 12•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•12 years ago
|
Assignee | ||
Comment 13•12 years ago
|
||
Is this annoying enough to be worth uplifting? I don't think it's a regression - it should be happening on previous versions of Fennec too.
Updated•12 years ago
|
Comment 14•12 years ago
|
||
I can verify this is fixed in a Galaxy S2 phone with Android 4.0.3 and the latest Aurora build.
Whiteboard: [testday-20130726]
Updated•12 years ago
|
tracking-fennec: ? → ---
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•