876099 - re-enable 3gp support

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Andreas Gal :gal]

Looks like mobile browsers support 3gp, so we won't get around it.

Comment 1

[Andreas Gal :gal]

Attachment: re-enable 3gp for web content (sigh)

Comment 2

[Andreas Gal :gal]

a=me to take this for the final IOT build, assuming we can sneak it in

Comment 3

[Jason Smith [:jsmith]]

(In reply to Andreas Gal :gal from comment #2)
> a=me to take this for the final IOT build, assuming we can sneak it in

We need someone to tef+ and get this landed asap then on the 1.01 branch.

Comment 4

[Andreas Gal :gal]

Comment on attachment 754079 [details] [diff] [review]
re-enable 3gp for web content (sigh)

Necessary for YT certification. Not holding the release over this, but approved to land.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Andreas Gal :gal from comment #4)
> Comment on attachment 754079 [details] [diff] [review]
> re-enable 3gp for web content (sigh)
> 
> Necessary for YT certification. Not holding the release over this, but
> approved to land.

That's not enough to get approval to land. You would need to land this on 1.01, which requires a tef+.

Comment 6

[Andreas Gal :gal]

Ok, done.

Comment 7

[[:fabrice] Fabrice Desré]

This patch doesn't apply on 1.0.1 - we don't do the principal check here at all, so I guess we use something else to prevent 3gp to play in web content?

Comment 8

[cajbir (:cajbir)]

(In reply to Fabrice Desré [:fabrice] from comment #7)
> This patch doesn't apply on 1.0.1 - we don't do the principal check here at
> all, so I guess we use something else to prevent 3gp to play in web content?

I don't think we stopped it in 1.0.1 so it just works.

Comment 9

[Daniel Coloma:dcoloma]

If we want to land this, can we do it before our partners create the final build, i.e. we need to land this before 26th May EOB PT.

Comment 10

[Kai-Chih Hu [:khu]]

(In reply to Chris Double (:doublec) from comment #8)
> (In reply to Fabrice Desré [:fabrice] from comment #7)
> > This patch doesn't apply on 1.0.1 - we don't do the principal check here at
> > all, so I guess we use something else to prevent 3gp to play in web content?
> 
> I don't think we stopped it in 1.0.1 so it just works.

Fabrice, in this case, can we land it to v1.0.1?

Comment 11

[Jason Smith [:jsmith]]

(In reply to khu from comment #10)
> (In reply to Chris Double (:doublec) from comment #8)
> > (In reply to Fabrice Desré [:fabrice] from comment #7)
> > > This patch doesn't apply on 1.0.1 - we don't do the principal check here at
> > > all, so I guess we use something else to prevent 3gp to play in web content?
> > 
> > I don't think we stopped it in 1.0.1 so it just works.
> 
> Fabrice, in this case, can we land it to v1.0.1?

Fabrice - Does that mean 3GP should already be working on 1.01? In that case, we don't even need this patch on 1.01, right?

Comment 12

[Alex Keybl [:akeybl]]

(In reply to Jason Smith [:jsmith] from comment #11)
> Fabrice - Does that mean 3GP should already be working on 1.01? In that
> case, we don't even need this patch on 1.01, right?

Have you confirmed that 3GP video is functional on v1.0.1?

Comment 13

[Jason Smith [:jsmith]]

(In reply to Alex Keybl [:akeybl] from comment #12)
> (In reply to Jason Smith [:jsmith] from comment #11)
> > Fabrice - Does that mean 3GP should already be working on 1.01? In that
> > case, we don't even need this patch on 1.01, right?
> 
> Have you confirmed that 3GP video is functional on v1.0.1?

Not yet. Let me put qawanted for someone to take a look.

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

As noted elsewhere. Note that this patch does *not* help with 3gp support for v1.0.1.

We still do *not* have a plan for how to enable 3gp for v1.0.1 other than in the YouTube app.

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

(In reply to Alex Keybl [:akeybl] from comment #12)
> (In reply to Jason Smith [:jsmith] from comment #11)
> > Fabrice - Does that mean 3GP should already be working on 1.01? In that
> > case, we don't even need this patch on 1.01, right?
> 
> Have you confirmed that 3GP video is functional on v1.0.1?

3GP is not functional in the browser app in v1.0.1. This is because we don't provide access to the decoding hardware for the browser process(es). And we don't have decoding software of good enough quality to use.

Providing access to the decoding hardware is not an option for v1.0.1 since it will result in background apps holding the decoding hardware and not permitting foreground apps to use it. I.e. it would mean that sometimes you can't watch videos at all.

Comment 16

[Jason Smith [:jsmith]]

In terms of this bug, the qawanted request appears to no longer apply. Although we still need to find a 3GP video to test the certified YouTube app with (which happening on a separate email thread).

Comment 17

[cajbir (:cajbir)]

(In reply to Jason Smith [:jsmith] from comment #16)
> In terms of this bug, the qawanted request appears to no longer apply.
> Although we still need to find a 3GP video to test the certified YouTube app
> with (which happening on a separate email thread).

I just tested the certified YouTube app. Using the non-HQ setting (ie the HQ button is gray) then 3GP's are served.

Comment 18

[[:fabrice] Fabrice Desré]

Attachment: rebased version for birch

Comment 19

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/birch/rev/d075c11ea5a0
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bc0f1c04e1da

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d075c11ea5a0

Comment 21

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Roc, Chris: Would it make sense to limit support for 3gp to a whitelist of domains? I'd hate for 3gp to become a required part of the web just because YouTube is sitting on 3gp encoded content that they don't want to reencode right now.

Or do you expect that a lot of other mobile websites benefit from 3gp support too?

Or is there no point in fighting over 3gp support given that we're having to support h264 anyway?

Comment 22

[Jason Smith [:jsmith]]

(In reply to Jonas Sicking (:sicking) from comment #21)
> Roc, Chris: Would it make sense to limit support for 3gp to a whitelist of
> domains? I'd hate for 3gp to become a required part of the web just because
> YouTube is sitting on 3gp encoded content that they don't want to reencode
> right now.
> 
> Or do you expect that a lot of other mobile websites benefit from 3gp
> support too?
> 
> Or is there no point in fighting over 3gp support given that we're having to
> support h264 anyway?

This feels like a good discussion topic for dev-media.

I did notice during my compatibility testing that the Terra mobile site made heavy use of 3GP media content. So I think there's definite value to investigating 3GP media content usage on the web today.