876148 - figure out a way to improve perf when there are a lot of sequences

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

This project here: popcorn.webmadecontent.org/13oj

It has 12 clips, and it starts to fall apart. It might not do it all the time, and the way it falls apart might not be the same as the last.

One problem is the clip is still loading, yet we allow play.

I suspect the ten second timeout is not enough for projects with this many clips.

I want to push this limit and make this project work better.

Comment 1

[Scott [:thecount] Downe]

I prototyped this on the weekend.

I am sure I can get a large performance and stability patch, in a relativly small amount of time. The win to work ratio here is huge.

I think we should consider doing this for the 15th or shortly after.

Brett, thoughts? How much of a concern is this for you? A demo for Friday may be possible.

Comment 2

[Brett Gaylor [:brett]]

Priority is make detail pages in both Popcorn Maker and Thimble.  If those land, take this, if not, next week.

Comment 3

[Scott [:thecount] Downe]

Sounds good.

Comment 4

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/85

First step for this.

I added a handler that can now control the order in which we load media clips.

Right now the order is just the order they were added.

This also has much better timeout control and flash is less likely to freak out when loading a lot of clips.

Comment 5

[Matthew Schranz [:mjschranz]]

Comment on attachment 770339 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/85

R- on the crash noted in IRC.

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 770339 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/85

STRs to the bug noted in IRC:

1. Add a clip.
2. Add an empty track event under that new clip.
3. Start playing the media.
4. click the new clip so it is selected.
5. Press the down key to move it to the new track.

Expected: Media should pause, then start playing when it is done loading the updated clip.

Actual: crash.

I fixed this by removing the offending line. I don't see that line doing anything anymore. I'm trying to find a path that currently breaks here. Nothing yet.

Comment 7

[Matthew Schranz [:mjschranz]]

Comment on attachment 770339 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/85

12:58 mjschranz: thecount: Mostly a nit for 876148, but is there any reason your readyEvent function can't also call this clearLoading function? I kind of like the idea of not registering multiple handlers for the same event

Really just that.

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 770339 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/85

Added a comment to the pull request explaining myself and why I came to the conclusion I came to.

Comment 9

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/4cf5a406f8fb12685a7d50126aba8673b7005ab7