876362 - CTP whitelist/blacklist doesn't work on dropbox.com

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Enable click to play
2. Open https://www.dropbox.com/
3. From the CTP doorhanger choose 'Always activate plugins for this site'
4. Reload page

Actual results:
CTP doorhanger is back again
It seems to be a regression in FF 20, works fine in FF 19.

Note: CTP whitelist/blacklist works fine on other flash sites: youtube.com, miniclip.com

Comment 1

[Paul Silaghi, QA [:pauly]]

Note: Setting directly through Page Info seems to work.

Comment 2

[Paul Silaghi, QA [:pauly]]

Last good nightly: 2012-11-27
First bad nightly: 2012-11-28

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=597915b66059&tochan
ge=3c3a8eed0578

Comment 3

[Georg Fritzsche [:gfritzsche]]

Apparently dropbox.com/home inserts Flash for "some time" when loading and removes it again.
When opening the "upload" dialog, Flash is again inserted into the page and i can use "always activate plugins for this site" just fine.

So it looks like bug 746374 breaks setting plugin permissions when the plugins were removed from the page already.

Comment 4

[Georg Fritzsche [:gfritzsche]]

David, is this something you could look into as a follow-up?

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Currently, the door-hanger sets permissions based on what plugins are in the page at the time the button is clicked. Additionally, if plugins are added to a page but then removed, we don't remove the notification. These two aspects make for a confusing corner-case as seen here, but I'm not sure what we even want to do about it. We could keep track of what plugins have been in a page and add permissions for all of them, but that doesn't seem entirely correct. We could try to remove the notification when there are no plugins in the page, but I think that will be difficult and slow unless someone knows of a shortcut.
Basically, I'm inclined to encourage dropbox to adopt a different strategy for their use of plugins.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Why do you think this isn't the correct behaviour?

Given that we won't get all sites to change their behaviour, i don't see why we shouldn't support this - especially as it's rather hard for a user to figure out how to get this to work otherwise.

Comment 7

[Benjamin Smedberg]

I just tried this and it appears that dropbox is no longer using Flash for file uploads but is using HTML drag and drop/file. In any case the doorhanger changes should make this work now.