87652 - Ok/Cancel buttons should be right-aligned on Windows

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Håkan Waara]

Seems like by default, the Ok/Cancel buttons are not right aligned. They should
be, as far as I remember.

Currently, it's not. I found out when I saw all the Ok/Cancel buttons *centered*
in all Editor dialogs.

Comment 1

[Håkan Waara]

The fix would be to add halign="right" to
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/win/platformDialogOverlay.xul
where the default Ok/Cancel buttons are defined for windows.

Comment 2

[Kathleen :Brade]

This is windows only; Mac buttons appear correct for me.

Comment 3

[Kathleen :Brade]

is this still a problem?

Comment 4

[Blake Ross]

This is a very good idea.  Centered is the special case, so dialogs should have
to ask for it (personally, I don't think it should be an option).  The system is
currently backwards.  usability/polish, 0.9.4.

Comment 5

[Håkan Waara]

Right, so we'd have okCancelButtonsRight for backwards compability, and then
make okCancelButtons halign="right".  If we still want to give the option to
have centered buttons, we could add okCancelButtonsCenter.

Comment 6

[Blake Ross]

Attachment: patch

Comment 7

[Kathleen :Brade]

The Mac patch is completely wrong.  Please do NOT check that in.

What about the "help" set of buttons?
Do we really need to have the "center" option?  We definitely don't need it for
the "help" variant.  Currently no one uses the default option (that isn't
right-aligned) according to http://lxr.mcom.com/ and
http://lxr.mozilla.org/seamonkey/ so it doesn't seem like we need to worry about
backward compatibility for the help option.  

I'd prefer to see a strategy where we make all buttons correct for the OS and
then see if there are any issues/places where people expect the non-standard layout.
Also, I'd prefer to see us remove the current "okCancelHelpButtons" definitions
and rename all occurrences of "okCancelHelpButtonsRight" to "okCancelHelpButtons"

Comment 8

[Blake Ross]

Uh, what?  How is the mac patch 'completely wrong'?  It just adds the same
Center group as the rest of the patches, affecting nothing at all in reality.

In any case, I don't care if we leave Center or not, unless that's expected on
some platform.  Alerts use it, but I don't think it's common enough that we have
to provide it in a package like this.

Also, yes, Composer is apparently using the default option in many places (or
not using this package at all), from the looks of its dialog.  In fact, Composer
used to be the only one whose dialogs all had centered buttons.  Luckily this
seems to have improved a bit in the past couple weeks, but some still are centered.

Comment 9

[Blake Ross]

I don't understand how your strategy is any different from what we're doing.

Yes, the okCancelHelpButtons need to be converted as well.

Comment 10

[Kathleen :Brade]

The Mac patch (and possibly others?) are wrong because the button order is
completely wrong.  I'd expect it to be much more like the "okCancelButtons" in
that file (not copy/pasted from some other platform's file).

In fact, this bug was filed because Composer's dialogs had centered buttons on
Windows and they shouldn't.  Unless someone objects, we should get rid of the
extra stuff and just have "okCancelButtons" and "okCancelHelpButtons"

Comment 11

[Kathleen :Brade]

Can we get this bug fixed?  Can I help?
I propose two phases:
 Phase 1: okCancelButtons are set to have halign="right" (also help version)
   - Monitor for bugs where people expect buttons to be centered
 Phase 2: all occurrences of "okCancelButtonsRight" are changed to 
"okCancelButtons"

If necessary, we can do Phase 3 to add the "Center" option (if someone really 
needs that)

Comment 12

[Håkan Waara]

Brade's idea sounds good to me.

Note that this bug is windows-only.

Comment 13

[Peter Trudelle]

Mass moving lower-priority bugs to 0.9.6 (with Blake's pre-consent) to make room
for remaining 0.9.4/eMojo bugs and MachV planning, performance and feature work.
 If anyone disagrees with the new target, please let me know.

Comment 14

[Charles Manske]

I'm trying to simplify my dialog bugs by coalescing all the very simple tasks
that touch multiple dialogs into one bug. This problem is not covered by
bug 93732.


*** This bug has been marked as a duplicate of 93732 ***

Comment 15

[Charles Manske]

Darn. Shouldn't have dupped this one -- it's about the more general issue of 
making right-align the default rather than "center" for Windows.

Comment 16

[Charles Manske]

Sorry, Blake!

Comment 17

[Blake Ross]

This is fixed.  <dialog> buttons have a default pack of end.

Comment 18

[sairuh (rarely reading bugmail)]

->sujay, could you pls vrfy this for the editor dialogs? thanks!

Comment 19

[sujay]

verified in 11/6 build that composer dialogs have OK/Cancel right aligned.