876528 - Esc key does not cancel a pending refresh (meta tag)

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[Carlos G Mendioroz]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:

Loaded a page that has an infinite refresh cycle. Press escape


Actual results:

nothing, i.e., page continues to be refreshed (reloaded) until you close it. 


Expected results:

It used to cancel the pending refresh, which sounds a better behaviour.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Carlos,

Can you please provide a web page that has a infinite refresh cycle so I can try to reproduce this issue on my end?

Also,can you please test this on the latest Firefox release (43.0.4) or latest Nightly (46.0a1, https://nightly.mozilla.org/) and tell me if this still reproduces for you ? When doing this please use a new fresh Firefox profile, maybe also in safe mode (https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems). 

Thanks,
Cosmin.

Comment 2

[Carlos G Mendioroz]

Version 4.0.3 still exhibits the same behaviour.
Pressing escape while the timer is running (waiting for the refresh t/o) does not cancel the refresh, i.e. the new page is loaded. Pressing escape during a page load does abort the process.

Comment 3

[Carlos G Mendioroz]

Here is a public page witha 5 seconds refresh. Pressing escape during the 5 second lapse should (used to) cancel the refresh.

http://www.htmlcodetutorial.com/document/autoforwardexample.html

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Carlos,

I have tested your issue on latest Firefox release (43.0.4) and latest Nightly (46.0a1) and I managed to reproduce it. Based on what you said (“It used to cancel the pending refresh”) I did some investigations on this using the Mozregression tool and found the version where the change occurred. 
Here is the build pushlog link (http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf26f61a0748&tochange=84320dffec6e). 
I looked over the fixed bugs and my guess is that the bug 614304 seems to be the one that changed browser functionality. Maybe Gavin could share an opinion on this. 

Thanks,
Cosmin.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

This was indeed an expected behavior change from bug 614304. The Esc key now only works when the stop button is enabled. I don't think it is worth revisiting (or complicating) for this very narrow use case.

Comment 6

[Carlos G Mendioroz]

I'm in no position to argue, but this could be a page saying "I will start this in 10 seconds" and you then have 10 seconds to do nothing if there is no way to abort.
It sounds to me conceptually wrong for it not to work. But who am I to say ? :)

Comment 7

[:Gijs (he/him)]

(In reply to Carlos G Mendioroz from comment #6)
> I'm in no position to argue, but this could be a page saying "I will start
> this in 10 seconds" and you then have 10 seconds to do nothing if there is
> no way to abort.

You can close the tab, right?

There is also an add-on Gavin wrote to keep the previous behaviour: https://addons.mozilla.org/en-US/firefox/addon/superstop/ .

Based on comment #5 I think this is essentially wontfix.