876570 - missing UngetToken() when failing to parse b part of :nth-child(an+b)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While writing additional tests during the process of reviewing bug 750388, I found that we failed a set of tests that I wrote.  The patch was trivial -- a missing UngetToken() call that is needed because the incorrect token might be a parenthesis, bracket, or brace, and predates bug 750388.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add missing UngetToken() call in an+b microsyntax parsing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 754651 [details] [diff] [review]
Add missing UngetToken() call in an+b microsyntax parsing.

Shouldn't the UngetToken happen after the REPORT_UNEXPECTED_TOKEN?

r=me with that or with a comment explaining the nonintuitive ordering in this case.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

From a behavior perspective it doesn't matter, since UngetToken just sets mHavePushBack and doesn't actually change mToken.  But you're right that it makes more sense that way (and most but not all of the existing occurrences of this pattern seem to be in that order).

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1b8487b6b6

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2b1b8487b6b6