Closed
Bug 876658
Opened 12 years ago
Closed 12 years ago
Autocorrect replaces word if no autocorrect is needed
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g18 fixed)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: janjongboom, Unassigned)
References
Details
Attachments
(1 file)
46 bytes,
patch
|
rudyl
:
review+
|
Details | Diff | Splinter Review |
Type a word, press space, the word in the textarea will flicker (as if it is replaced) even if the word keeps the same.
Reporter | ||
Comment 1•12 years ago
|
||
Currently the word is replaced by the new word even if the 2 words are the same. Because this is blocking you'll see a flicker, which is pretty annoying. This patch fixes that.
Attachment #754788 -
Flags: review?(dflanagan)
Comment 2•12 years ago
|
||
I'm at a workweek for two days and focused on other bugs right now, so can't do a complete review. We should really fix this one, though. I'm surprised that the patch has to be as long as this one is. Is there a way to simply avoid calling autoCorrect in the first place, rather than modifying autoCorrect?
Flags: needinfo?(janjongboom)
Reporter | ||
Comment 3•12 years ago
|
||
Yeah, I agree, I've been running this branch on my phone and it already makes a huge difference. Regarding the patch, you were very right so, got caught up this way and didn't see the obvious solution of just adding a new condition to the if statement in `handleCorrections`. Added it now. I didn't change the calls for the `select` function as calling this is outside of scope of latin.js, and maybe a different IME wants to handle it anyway, so let's keep it there for now. OK?
Flags: needinfo?(janjongboom) → needinfo?(dflanagan)
Reporter | ||
Comment 4•12 years ago
|
||
Other than that, if you don't have any time to review please set the r? flag to any of the peers for the Keyboard.
Reporter | ||
Updated•12 years ago
|
Attachment #754788 -
Flags: review?(dflanagan) → review?(rlu)
Comment 5•12 years ago
|
||
Comment on attachment 754788 [details] [diff] [review] Proposed patch to omit replacing if words are the same looks good. r=me. Jan, Thanks for your work.
Attachment #754788 -
Flags: review?(rlu) → review+
Reporter | ||
Comment 6•12 years ago
|
||
Landed in https://github.com/mozilla-b2g/gaia/commit/bebcb40d4fe8539674f166ab057e93c9a19c1751
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(dflanagan)
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
Auto Correct replaces a corrctly spelled word and replaces it with the same spelling with a space after the word. Tested on b2g/nightly/mozilla-central-unagi/latest. Kernel Date: Dec 5 Gecko: http://hg.mozilla.org/mozilla-central/rev/3c6f2394995d Gaia: d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b
Status: RESOLVED → VERIFIED
Comment 8•11 years ago
|
||
Please add a testcase for this bug to moztrap for 1.1 testsuite. If yes, mark this in-moztrap+ when completed. If not, mark this in-moztrap-.
Flags: in-moztrap?(cschmoeckel)
Comment 9•11 years ago
|
||
Added Keyboard Suite Test Case #8452 - [Keyboard] The Auto Correct feature replaces characters in a word even when a word is spelled correctly
Flags: in-moztrap?(cschmoeckel) → in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•