876670 - BaselineCompiler: Compile JSOP_GETTER and JSOP_SETTER

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

The interpreter code for these ops could also use some refactoring..

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

The way these ops currently work is that JSOP_GETTER and JSOP_SETTER are always followed by either JSOP_INITPROP or JSOP_INITELEM and the interpreter then fuses the two ops.

To avoid having to do the same in the baseline compiler, I replaced JSOP_GETTER/SETTER with JSOP_INITPROP_GETTER/SETTER and JSOP_INITELEM_GETTER/SETTER. With that change these ops are much simpler/cleaner to implement in both the interpreter and Baseline (and Ion later on).

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Patch

Forgot to qref the test.

Comment 3

[Brian Hackett [Laid off!]]

Comment on attachment 755240 [details] [diff] [review]
Patch

Review of attachment 755240 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinterp.cpp
@@ +2602,5 @@
> +    obj = &regs.sp[-2].toObject();
> +    name = script->getName(regs.pc);
> +    val = regs.sp[-1];
> +
> +    if (!InitGetterSetter(cx, regs.pc, obj, name, val))

Maybe InitGetterSetterOperation?

Comment 4

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/005c4f452f1e

(Green on OS X/Linux Try: https://tbpl.mozilla.org/?tree=Try&rev=220e45bc7f96)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/005c4f452f1e