876712 - Kill AweseomeBar/AwesomeBarTabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

They're not used in our new BrowserToolbar/HomePager world.

Aside: Maybe we should make a new bugzilla component for this new about:home feature ("Home Page"?), and retire the Awesomescreen component. We can migrate bugs that are still relevant, but I bet a lot of them won't be.

Comment 1

[:Margaret Leibovic]

Attachment: (Part 1) Rename awesomebar_contextmenu to home_contextmenu

An awesomebar variable name made it into BookmarksPage! Getting rid of that :)

Comment 2

[:Margaret Leibovic]

Attachment: (Part 2) Mega patch to kill AwesomeBar code

I want to get multiple eyes on this. A build with this appears to work fine, so I'm pretty sure we're not dependent on any of this code anymore.

I made a comment about this in bug 879979, but we're going to have to do a lot of work to update robocop tests to get rid of their dependency on the AwesomeBar activity. I'm punting on that for now and will address it in a separate bug.

Also, I filed bug 880047 about removing the unused AboutHome stuff.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Someone just did a "sudo killall awesomebar" :D

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 758870 [details] [diff] [review]
(Part 2) Mega patch to kill AwesomeBar code

Review of attachment 758870 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not entirely happy with removing some of these things that it seems like we'll just end up adding back. suggestion prompts, basic row layouts... but I've been losing my battle not to delete code. If this builds and is what we want to do, looks fine.

::: mobile/android/base/Makefile.in
@@ -1059,5 @@
>    mobile/android/base/resources/drawable/url_bar_entry.xml                      \
>    mobile/android/base/resources/drawable/url_bar_nav_button.xml                 \
>    mobile/android/base/resources/drawable/url_bar_right_edge.xml                 \
> -  mobile/android/base/resources/drawable/awesomebar_listview_divider.xml        \
> -  mobile/android/base/resources/drawable/awesomebar_header_row.xml              \

Do we want to keep the around? I'm not sure we have mockups for the history pane.

::: mobile/android/base/widget/TopSitesView.java
@@ -672,5 @@
> -                }).execute();
> -            }
> -        });
> -
> -        mActivity.startActivityForResult(intent, requestCode);

Is there a bug filed to reimplement this (somehow...)?

Comment 5

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #4)

> ::: mobile/android/base/Makefile.in
> @@ -1059,5 @@
> >    mobile/android/base/resources/drawable/url_bar_entry.xml                      \
> >    mobile/android/base/resources/drawable/url_bar_nav_button.xml                 \
> >    mobile/android/base/resources/drawable/url_bar_right_edge.xml                 \
> > -  mobile/android/base/resources/drawable/awesomebar_listview_divider.xml        \
> > -  mobile/android/base/resources/drawable/awesomebar_header_row.xml              \
> 
> Do we want to keep the around? I'm not sure we have mockups for the history
> pane.

I think the layouts will be different enough that it doesn't make sense to keep these around. We can also refer to them if necessary when re-implementing.

> ::: mobile/android/base/widget/TopSitesView.java
> @@ -672,5 @@
> > -                }).execute();
> > -            }
> > -        });
> > -
> > -        mActivity.startActivityForResult(intent, requestCode);
> 
> Is there a bug filed to reimplement this (somehow...)?

I don't even know what "pinning" things is supposed to look like in the new about:home, since it will be part of the bookmarks tab. I think this will need to be reimplemented a new way as part of that new feature.

I was thinking TopSitesView would be unused now, but actually I wonder how hard it would be to just plug it into the bookmarks tab, just making modifications to the data that's backing the adapter.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/projects/fig/rev/13e4b6ac5410
https://hg.mozilla.org/projects/fig/rev/00ef1efa58bf

Sigh, I noticed I forgot to remove some files. I'll upload another patch.

Comment 7

[:Margaret Leibovic]

Attachment: (Part 3) Remove more unused awesomebar_* files, and rename awesomebar_suggestion_row.xml

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 761658 [details] [diff] [review]
(Part 3) Remove more unused awesomebar_* files, and rename awesomebar_suggestion_row.xml

Review of attachment 761658 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. Please clean up the styles, that uses awesomebar_layout. You could search for "actionBarLayout" or something (should be under values-v11).

Comment 9

[:Margaret Leibovic]

(In reply to Sriram Ramasubramanian [:sriram] from comment #8)
> Comment on attachment 761658 [details] [diff] [review]
> (Part 3) Remove more unused awesomebar_* files, and rename
> awesomebar_suggestion_row.xml
> 
> Review of attachment 761658 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good. Please clean up the styles, that uses awesomebar_layout.
> You could search for "actionBarLayout" or something (should be under
> values-v11).

I believe I already did that in the last patch, right? I already removed these from the Makefile, but I had forgot to hg rm them.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/projects/fig/rev/d9df2bdc40bb

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/13e4b6ac5410
https://hg.mozilla.org/mozilla-central/rev/00ef1efa58bf
https://hg.mozilla.org/mozilla-central/rev/d9df2bdc40bb