Closed Bug 876717 Opened 7 years ago Closed 7 years ago

ASan startup crash with Clang 3.3rc1

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: decoder, Unassigned)

References

(Blocks 1 open bug)

Details

With the Clang 3.3rc1 version that we're aiming for in bug 870173, we do have a startup crash on ASan which renders ASan unusable and therefore blocks the update. It crashes because we call clock_gettime in the main binary but it is not linked to librt (instead, libxul.so is linked to it and that is dlopened). ASan now intercepts clock_gettime and calls a NULL ptr when calling the real function.

ASan devs solved this already for us: Revision r182645 in the clang repository fixes this by forcing -lrt when clang links the ASan runtime. The patch is easy and should also be easy to apply/backport to the revision we're aiming for.
Nathan, can you see if you can get that patch upstreams on 3.3?
Flags: needinfo?(nfroyd)
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: catlee
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> Nathan, can you see if you can get that patch upstreams on 3.3?

Request sent; will follow up as needed.
Flags: needinfo?(nfroyd)
The patch landed in the 3.3 repo as of r182944.  Christian, I assume that means we can close this?
Flags: needinfo?(choller)
Sure, if the patch is backported, then this shouldn't be an issue anymore :) I can't check it right now, but I tested the original patch and that fixed the issue, so closing this as FIXED.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(choller)
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.