Closed
Bug 877003
Opened 11 years ago
Closed 11 years ago
Convert TestSettingsAPI.cpp to a mochitest-chrome
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: reuben, Assigned: reuben)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(1 file, 1 obsolete file)
14.92 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #755137 -
Flags: review?(fabrice)
Comment 2•11 years ago
|
||
Comment on attachment 755137 [details] [diff] [review] Convert TestSettingsAPI.cpp to a mochitest-chrome Review of attachment 755137 [details] [diff] [review]: ----------------------------------------------------------------- Overall looks good to me, but I'd like to see a new version with that answered: - you use the same callback for both locks, and then ignore some values of callbackCount. That looks fragile if we update the test. Can we either test all the callback states, of split up those we don't care about? - am I right that TestSettingsAPI.cpp was not even compiled before?
Attachment #755137 -
Flags: review?(fabrice) → feedback+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Fabrice Desré [:fabrice] from comment #2) > - am I right that TestSettingsAPI.cpp was not even compiled before? Yes. It was disabled in bug 852429 and never re-enabled when bug 862355 got fixed.
Attachment #755137 -
Attachment is obsolete: true
Attachment #756044 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #756044 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Landed: https://hg.mozilla.org/projects/birch/rev/f2d4762e07f9 And backed out: https://hg.mozilla.org/projects/birch/rev/6eac1d687575
Assignee | ||
Comment 5•11 years ago
|
||
Let's try this again: https://hg.mozilla.org/projects/birch/rev/0fc4fb4f4e37
Whiteboard: [fixed-in-birch]
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0fc4fb4f4e37
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•