Closed Bug 877003 Opened 11 years ago Closed 11 years ago

Convert TestSettingsAPI.cpp to a mochitest-chrome

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: reuben, Assigned: reuben)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attachment #755137 - Flags: review?(fabrice)
Comment on attachment 755137 [details] [diff] [review]
Convert TestSettingsAPI.cpp to a mochitest-chrome

Review of attachment 755137 [details] [diff] [review]:
-----------------------------------------------------------------

Overall looks good to me, but I'd like to see a new version with that answered:
- you use the same callback for both locks, and then ignore some values of callbackCount. That looks fragile if we update the test. Can we either test all the callback states, of split up those we don't care about?
- am I right that TestSettingsAPI.cpp was not even compiled before?
Attachment #755137 - Flags: review?(fabrice) → feedback+
(In reply to Fabrice Desré [:fabrice] from comment #2)
> - am I right that TestSettingsAPI.cpp was not even compiled before?
Yes. It was disabled in bug 852429 and never re-enabled when bug 862355 got fixed.
Attachment #755137 - Attachment is obsolete: true
Attachment #756044 - Flags: review?(fabrice)
Attachment #756044 - Flags: review?(fabrice) → review+
Blocks: 852429
Let's try this again:

https://hg.mozilla.org/projects/birch/rev/0fc4fb4f4e37
Whiteboard: [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/0fc4fb4f4e37
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: