877048 - Split android mochitest-gl test known failures for panda vs tegra2.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

mochitest-gl is running 'fine' on Pandas (Android 4.0 slaves), but has a different set of failed tests on Tegra 2. (Android 2.2 slaves)

At minimum, we need to add differentiation between these two configs, with different failed test lists.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 1: Factor getting driver info out into a self-contained function.

There is an unnecessary level of interconnectedness here that we can eliminate by just returning `[VENDOR, RENDERER]` and letting the code act on those directly.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 2: Make OS, version, and driver detection more modular.

Use interchangeable parts instead of a list of mutually exclusive bools.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 3: Add new path for android+nvidia for the tegra2 slaves, and its failing test file.

Just add the tests which are failing. 'General' android failed tests (really Panda) include a bunch of the skipped tests too. Really we should either skip or mark failing, and not allow a test to be in both groups, but we can do that later.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 4: Fix quotes to consistently use `'` for strings. (changed code only)

The whole file should use only one of single or double quotes, but that's beyond the scope of this bug.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 5: Add support for comments and whitespace trimming to failing/skipped test files.

Comment 6

[Kelsey Gilbert [:jgilbert]]

For patches 1 and 2:
https://tbpl.mozilla.org/?tree=Try&rev=78fb967029d1&showall=1

For all patches, but only on android:
https://tbpl.mozilla.org/?tree=Try&showall=1&rev=f8fdae193270

Comment 7

[Kelsey Gilbert [:jgilbert]]

If a couple of these patches, we also add debug lines with `info()` which help assure that we really are testing what we think we're testing.

Total new log spew is ~10+<failing tests>+<skipped tests> lines, or about 80 on the worst platform. (Android 4.0)

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 755177 [details] [diff] [review]
patch 5: Add support for comments and whitespace trimming to failing/skipped test files.

Review of attachment 755177 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/test/webgl/test_webgl_conformance_test_suite.html
@@ +554,5 @@
> +    // Remove comments and trim whitespace.
> +    var retLines = [];
> +    for (var i = 0; i < lines.length; i++) {
> +      var line = lines[i];
> +      line = line.split('#', 1)[0].trim();

ooooh neat.

Comment 9

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50d048871440
https://hg.mozilla.org/integration/mozilla-inbound/rev/8275eae29044
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab2ac31dfe0e
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd4a3273281b
https://hg.mozilla.org/integration/mozilla-inbound/rev/79cd6c91292b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/50d048871440
https://hg.mozilla.org/mozilla-central/rev/8275eae29044
https://hg.mozilla.org/mozilla-central/rev/ab2ac31dfe0e
https://hg.mozilla.org/mozilla-central/rev/fd4a3273281b
https://hg.mozilla.org/mozilla-central/rev/79cd6c91292b