877070 - [Dialer]Dial the last outgoing call instead of doing last record of call log when doing BT redial

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

During BQB certification, lab reports we need to do last "outgoing" call, instead of the last record of call log.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

I'm not sure if it is possible using multiple keys (outgoing, timestamp) in the cursor. If no, maybe we need to store the latest outgoing call in async storage.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10070

Pointer to Github pull-request

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

In the worst case, it needs to iterate all of the calls. Or we simply store the last outgoing calls?

Comment 4

[Daniel Coloma:dcoloma]

Does it block BT certification?

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 755288 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10070

[Root Cause]
Dialer app would always find the last number for BT redial not matter it is a incoming or outgoing call.

[Solution]
Iterate the recent call DB (backwards), and find the last outgoing call number.

Hi Etienne,

Could you please review this simple patch?

I think what Arthur mentioned in Comment 3 makes sense, but should be a corner case. This patch should be simpler and with lower risk.

Thank you.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi David, we got request from partner, lab requests to change this behavior.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

batch update on tef+ milestones. partner to make a final on 6/3 Asia time. TEF+ needs to be resolved by 6/3 to be in the final build. thanks

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 755288 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10070

My comments are on github.

Please flag me for review again as soon as they are fixed.
We also need to file a a follow up bug for master and v1-train (it will be a completely different patch because of the call log refactoring).

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 755288 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10070

Hi Etienne,

Just update the pull request to address your comment.
Please help review it again.

Thanks.

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 755288 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10070

r=me

Please squash before landing.

Thanks!

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Etienne,

Thanks for the review.

Merged to Gaia v1.0.1,
f13d8be2ff848bae3d72cd83a69abea5e3572311

Note: Gaia master does not have the related changes yet.
As Comment 8 suggested, might need to handle this with another bug.

Comment 12

[Etienne Segonzac (:etienne)]

(In reply to Rudy Lu [:rudyl] from comment #11)
> Etienne,
> 
> Thanks for the review.
> 
> Merged to Gaia v1.0.1,
> f13d8be2ff848bae3d72cd83a69abea5e3572311
> 
> Note: Gaia master does not have the related changes yet.
> As Comment 8 suggested, might need to handle this with another bug.

Yes, please open the follow up bug right away (and cc me) before it slips.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Bug 878184 has been created to track this work for Gaia v1-train and master as suggested with Comment 12.
Thanks.