877140 - Fade in toolbar buttons while hiding tabs tray

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Attachment: Change animation

...instead of waiting until the tabs tray is closed to started the fade in animation.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Fade in toolbar buttons while hiding tabs tray

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 755388 [details] [diff] [review]
Fade in toolbar buttons while hiding tabs tray

iterate, iterate, iterate :)

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: (1/3) Fix type of constructor argument for duration

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: (2/3) Add duration getter to PropertyAnimator

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: (3/3) Fade in toolbar buttons while hiding tabs tray

Comment 6

[Lucas Rocha (:lucasr)]

FYI: the new patches implement the behaviour that ibarlow and I agreed on.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aca1f06739e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed0935b6ec1a
https://hg.mozilla.org/integration/mozilla-inbound/rev/55a08c564f74

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aca1f06739e5
https://hg.mozilla.org/mozilla-central/rev/ed0935b6ec1a
https://hg.mozilla.org/mozilla-central/rev/55a08c564f74