Closed
Bug 877265
Opened 11 years ago
Closed 11 years ago
mozdevice.dmcli uses dictionary comprehensions which are a python 2.7ism
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: ahal, Assigned: wlach)
References
Details
Attachments
(1 file)
|
1.36 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
While nice, unfortunately it trips up any slaves on python 2.6 (or less) when trying to install mozdevice: e.g https://tbpl.mozilla.org/php/getParsedLog.php?id=23535012&tree=Ash&full=1#error0 Line tripping it up: https://github.com/mozilla/mozbase/blob/f4f1a4d90fdbb8105c5a873566649637be3beea1/mozdevice/mozdevice/dmcli.py#L174
|
Assignee | |
Comment 1•11 years ago
|
||
I can't believe we're not using python 2.7 on these slaves, but that's another story. Let's just get this fixed.
Assignee: nobody → wlachance
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #755949 -
Flags: review?(ahalberstadt)
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 755949 [details] [diff] [review] Make dmcli parseable by python 2.6 Review of attachment 755949 [details] [diff] [review]: ----------------------------------------------------------------- Just be glad they are running python 2.6 and not 2.4/2.5 like they were until recently ;)
Attachment #755949 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Pushed to github: https://github.com/mozilla/mozbase/commit/ae063d24cfeee5942ba00096afa3a2e601a94993
|
|
Assignee | |
Comment 5•11 years ago
|
||
Fix pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/119135e2c22b
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/119135e2c22b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•