877344 - facebook.com - Comments field displays all previous entries

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect, P2)

Description

[Karen Rudnitski [:kar]]

Attachment: screenshot

Nexus 4. Go to the mobile facebook site. Click on 'comment' on someone's post. Tons of previous comments are automatically listed in there. Not very cool.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

is this a regression?

Comment 2

[Karen Rudnitski [:kar]]

yes. 

granted, the comments field never has behaved completely properly (just about to log another bug on it), but it has never done this before. Although I would guess that I started seeing it a couple of weeks ago.

Comment 3

[Jason Smith [:jsmith]]

Is this a TE bug by any chance?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Jason Smith [:jsmith] from comment #3)
> Is this a TE bug by any chance?

I strongly suspect that this is an invalid bug and works as expected, but Karen says it is a regression, which is why are looking for a regression range.

Comment 5

[Karen Rudnitski [:kar]]

checked again today. It happens on nightly and aurora, but not on beta.

Comment 6

[:Margaret Leibovic]

(In reply to Karen Rudnitski [:kar] from comment #5)
> checked again today. It happens on nightly and aurora, but not on beta.

Perhaps this is related to bug 566746?

Gavin or Mark, have you guys seen any similar complaints on desktop?

Comment 7

[:Margaret Leibovic]

If this is a regression, it would be great to try to get a reduced testcase.

Cc'ing Martijn, since he has an arsenal of form autocomplete testcases :)

Comment 8

[Martijn Wargers (dead)]

I can reproduce this on trunk and on Firefox beta.

I don't think this is in Fennec, there is no autocomplete="off" attribute on the relevant text input or the form.
When spoofing as iPhone 3, then autocomplete is turned off.
Also checked with Google Chrome, they also get a proper version of the page served with autocomplete off.

So I think this is tech evangelism.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

(In reply to :Margaret Leibovic from comment #6)
> (In reply to Karen Rudnitski [:kar] from comment #5)
> > checked again today. It happens on nightly and aurora, but not on beta.
> 
> Perhaps this is related to bug 566746?
> 
> Gavin or Mark, have you guys seen any similar complaints on desktop?

Nope, I've never heard anything like this.

Comment 10

[Hallvord R. M. Steen [:hallvors]]

Isn't this just about firefox remembering past comments you typed in some form elements and offering them for auto-completion? This feature is typically used for INPUT fields (not, however, for TEXTAREAs where you typically want to type very different things from time to time).

Online, comment fields happen to mostly be coded as TEXTAREAs, so this distinction served us fine. Along comes Facebook and makes an INPUT field a comment field, and our logic is suddently not quite perfect anymore..

This is not really tech evangelism. Although, if Firefox respects autocomplete=off for this feature, we could ask Facebook very, very nicely to add autocomplete=off to their comment INPUT..

Comment 11

[Jason Smith [:jsmith]]

Android bug, not a FxOS bug - back over to Mobile

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Harald, this looks to be Firefox specific content served by Facebook. See comment 8. Can you please ask Facebook to turn autocomplete off for Firefox as well?

Comment 13

[Hallvord R. M. Steen [:hallvors]]

(do we know that Firefox respects autocomplete=off here? Just checking..)

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Brad - Can you confirm comment 13?

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

yup 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/nsFormFillController.cpp#862
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsContentUtils.cpp#682

I'll be off for any value other than empty or "on"

Comment 16

[:Harald Kirschner :digitarald]

We'll meet with them next week, I'll bring this up then.

Comment 17

[Hallvord R. M. Steen [:hallvors]]

Harald, done? We'll change [contactready] to [sitewait] if we're waiting for a response :)

Comment 18

[:Harald Kirschner :digitarald]

Could you have a look at that, Colby?

Comment 19

[Karl Dubost💡 :karlcow]

Colby,

Any status?

Comment 21

[Michael Ellis]

Clearing NI - Colby is no longer at Fb

Closing this bug due to a lack of activity.  If needed, feel free to reopen this bug.