877364 - [traceback] UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 21: ordinal not in range(128)

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/login?lang=fr
2. Log in with valid credentials
3. Load https://marketplace-dev.allizom.org/developers/submit/

observed behavior:
Submission form 500s in french but works fine in English.

"NetworkError: 500 INTERNAL SERVER ERROR - https://marketplace-dev.allizom.org/developers/submit/"

I don't see any tracebacks in sentry

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This blocks buchets from going live.

http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/14357/

UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 21: ordinal not in range(128)

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)
  File "amo/decorators.py", line 157, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "mkt/submit/views.py", line 42, in submit
    return manifest(request)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "mkt/submit/decorators.py", line 37, in wrapper
    return f(request, *args, **kw)
  File "mkt/submit/decorators.py", line 21, in wrapper
    return f(request, *args, **kw)
  File "django/db/transaction.py", line 224, in inner
    return func(*args, **kwargs)
  File "mkt/submit/views.py", line 132, in manifest
    'DEVICE_LOOKUP': DEVICE_LOOKUP
  File "jingo/__init__.py", line 80, in render
    rendered = render_to_string(request, template, context)
  File "jingo/__init__.py", line 98, in render_to_string
    return template.render(**get_context())
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/api/function_trace.py", line 82, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/submit/templates/submit/manifest.html", line 15, in top-level template code
    <div>{{ DEVICE_LOOKUP[item[0]] }}</div>
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/templates/developers/base_impala.html", line 8, in top-level template code
    {% set editable = "no-edit"
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/templates/developers/skeleton_impala.html", line 114, in top-level template code
    {% block main_content %}
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/templates/developers/skeleton_impala.html", line 117, in block "main_content"
    {% block content %}{% endblock %}
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/submit/templates/submit/manifest.html", line 110, in block "content"
    {% for field in features_form.required_api_fields() %}
  File "mkt/submit/forms.py", line 424, in required_api_fields
    return sorted(self.all_fields(), key=lambda x: x.help_text.decode())
  File "mkt/submit/forms.py", line 424, in <lambda>
    return sorted(self.all_fields(), key=lambda x: x.help_text.decode())
  File "django/utils/functional.py", line 111, in __wrapper__
    return self.__dispatch[t][funcname](res, *args, **kw)

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/8cfaa5ba327#commitcomment-3313419

Comment 3

[Kumar McMillan [:kumar]]

All instances of .decode() need to be removed from this patch because help_text is always localized (it will break in non-ascii locales): https://github.com/mozilla/zamboni/commit/8cfaa5ba327 

You probably want help_text.encode('ascii', 'ignore') but I'm not sure why it's even necessary to encode if you're just creating a sort key. If that sounds confusing, find me on IRC and I can elaborate.

Comment 4

[Chuck Harmston [:chuck]]

Fix landed here: https://github.com/mozilla/zamboni/commit/6aac47c4a848646897c06d4890b7765be8818f8d

Comment 5

[Victor Carciu]

Verified as fixed : http://screencast.com/t/uOMDhcpK1o .
https://marketplace-dev.allizom.org/developers/submit/ is correctly loading after entering https://marketplace-dev.allizom.org/login?lang=fr .