877370 - Drag and drop effects for the Australis menu panel

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Follow-up from bug 873056.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: WIP Patch

This patch includes placeholder elements in the panel when in customization mode. Still need to fix a bug with the styling of them and implement the animation part.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch (part 1)

This patch puts placeholders in the palette while customizing. Borders of them show up when an item is being dragged, to be consistent with how we are styling the nav-bar during drags.

I'm moving the animation to a second patch for this bug. Or we could move the animation to a follow-up, I'm indifferent.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 756752 [details] [diff] [review]
Patch (part 1)

It doesn't look like the placeholders are being correctly removed in some cases.

STR on OSX:

1) Open up customization mode, and drag some items into the panel.
2) Exit customization mode
3) Open the panel

This is what I see: http://i.imgur.com/TRdN5c4.png

So I don't think those nodes are being removed correctly.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2 (part 1)

Sorry about that first patch, I should have cleared review when I started to notice I needed to change more things. This patch should get the interactions right, but doesn't have the panel items animating their movement. I think this is a landable chunk by itself though.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 757461 [details] [diff] [review]
Patch v2 (part 1)

Review of attachment 757461 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. r=me with two nits fixed.

::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +904,5 @@
> +  _showPanelCustomizationPlaceholders: function() {
> +    this._removePanelCustomizationPlaceholders();
> +    let doc = this.document;
> +    let contents = this.panelUIContents;
> +    const kColumns = 3;

Let's put the const at the top of this function. Maybe sometime down the line it should be moved into panelUI.js, but I'm find with it being here for now.

@@ +921,5 @@
> +    }
> +  },
> +
> +  _removePanelCustomizationPlaceholders: function() {
> +    let doc = this.document;

doc is never used and can be removed.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/92f65b23b5f4

For ease of tracking, I'll move the panel animations to another bug.

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/92f65b23b5f4