Closed Bug 877370 Opened 8 years ago Closed 7 years ago

Drag and drop effects for the Australis menu panel


(Firefox :: Toolbars and Customization, defect)

Not set



Firefox 28


(Reporter: jaws, Assigned: jaws)


(Blocks 1 open bug)


(Whiteboard: [Australis:M6])


(1 file, 2 obsolete files)

Follow-up from bug 873056.
Attached patch WIP Patch (obsolete) — Splinter Review
This patch includes placeholder elements in the panel when in customization mode. Still need to fix a bug with the styling of them and implement the animation part.
Assignee: nobody → jaws
Attached patch Patch (part 1) (obsolete) — Splinter Review
This patch puts placeholders in the palette while customizing. Borders of them show up when an item is being dragged, to be consistent with how we are styling the nav-bar during drags.

I'm moving the animation to a second patch for this bug. Or we could move the animation to a follow-up, I'm indifferent.
Attachment #756175 - Attachment is obsolete: true
Attachment #756752 - Flags: review?(mconley)
Comment on attachment 756752 [details] [diff] [review]
Patch (part 1)

It doesn't look like the placeholders are being correctly removed in some cases.


1) Open up customization mode, and drag some items into the panel.
2) Exit customization mode
3) Open the panel

This is what I see:

So I don't think those nodes are being removed correctly.
Attachment #756752 - Flags: review?(mconley) → review-
Sorry about that first patch, I should have cleared review when I started to notice I needed to change more things. This patch should get the interactions right, but doesn't have the panel items animating their movement. I think this is a landable chunk by itself though.
Attachment #756752 - Attachment is obsolete: true
Attachment #757461 - Flags: review?(mconley)
Comment on attachment 757461 [details] [diff] [review]
Patch v2 (part 1)

Review of attachment 757461 [details] [diff] [review]:

Looks reasonable. r=me with two nits fixed.

::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +904,5 @@
> +  _showPanelCustomizationPlaceholders: function() {
> +    this._removePanelCustomizationPlaceholders();
> +    let doc = this.document;
> +    let contents = this.panelUIContents;
> +    const kColumns = 3;

Let's put the const at the top of this function. Maybe sometime down the line it should be moved into panelUI.js, but I'm find with it being here for now.

@@ +921,5 @@
> +    }
> +  },
> +
> +  _removePanelCustomizationPlaceholders: function() {
> +    let doc = this.document;

doc is never used and can be removed.
Attachment #757461 - Flags: review?(mconley) → review+

For ease of tracking, I'll move the panel animations to another bug.
Whiteboard: [Australis:M?] → [Australis:M6][fixed-in-ux]
Depends on: 879863
Depends on: 919965
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M6][fixed-in-ux] → [Australis:M6]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.