Closed Bug 87739 Opened 25 years ago Closed 25 years ago

When an image is cancelled it disappears from the document...

Categories

(Core :: Graphics: ImageLib, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.4

People

(Reporter: rpotts, Assigned: pavlov)

References

Details

(Keywords: topembed, Whiteboard: PDT, fixed on trunk)

Attachments

(1 file)

if a document which is being loaded is cancelled, any partially rendered images will disappear. It appears that this is because the partially rendered image is removed from the image cache :-( The desired behavior is to continue displaying the partial image :-)
DUP bug 41924.. I hope this is fixed soon, one of Mozilla's real irritants. *** This bug has been marked as a duplicate of 41924 ***
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
How is this a dup of bug #41924? It seems as if that bug is dealing with the situation when the actual image is not yet available. This bug is for the case where the image is partially displayed, but then dissappears after it has been canceled. This bug is VERY important for 0.9.3 -- rick
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
more comments... in this situation, I don't want to see the broken image icon (which bug #41924 is about) I want to see the part of the image which has already been rendered.
I believe that part of this fix (at least for full-page images) will depend on bug #87370... Since without this patch, imglib will *never* receive an OnStopRequest notification :-(
Depends on: 87370
Status: REOPENED → ASSIGNED
Keywords: topembed
Priority: -- → P2
Target Milestone: --- → mozilla0.9.3
-> 0.9.4
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Tested against 0.9.4 trunk yesterday. No change with imglib2 landing. Image still disappears when canceling. Image is being streamed via a protocol handler implementing nsIInputStream.
hey pav, we need this fixed as soon as possible!! Do you have an ETA? -- rick
I'll take a look at this today
Attached patch fix — — Splinter Review
Ok.. So when Cancel is called on imgRequestProxy, it removes itself as normal.. when all of of the imgReqestProxy's are removed from the imgRequest, and if the channel is still going, it will set the imgIRequest::STATUS_LOAD_PARTIAL flag. This is mutually exclusive to imgIRequest::STATUS_LOAD_COMPLETE. When there is an error decoding the image, or from the channel, imgIRequest::STATUS_ERROR will be set, and the image should change in to the alt text. mOwner is no longer nulled out when imgRequestProxy::Cancel is called, since this is called from the LoadGroup when stop is pressed. This allows people to ask for the status and image after Cancel has been called. Since the imgRequestProxy object holds a strong reference to the imgRequest (mOwner), and once Cancel is called, imgRequest does not hold a reference to the imgRequestProxy, the imgRequest will just go away eventually when the imgRequestProxy object finally goes away.
Keywords: patch
r/sr=darin
what darin said, r=dougt.
checked in on trunk.. is this needed on the branch?
Whiteboard: fixed on trunk
needed on the 9_2 branch. thanks !
This appears to fix the disappearing problem, but causes another, assuming I patched and rebuilt properly. Now when I cancel an image load, the partial image remains. However, closing and reopening should re-request the original data. However, the partial image immediately displays and never gets updated. It looks like the partial image is coming from the cache? It shouldn't, as I explicitly specify nsIWebNavigation::LOAD_FLAGS_BYPASS_CACHE on the load request.
Interesting. This morning I destroyed my cache directory to confirm that nothing is read/written to it... now when I stream that same data I don't see any images, just empty frames.
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Target Milestone: mozilla0.9.5 → mozilla0.9.4
ah. ok.. moving back to 0.9.4 i'll look into this problem before I land on the branch.
I don't see the reload problem.
Stuart - Are you actually testing this with CS mail?
I tested this in a mozilla build on the trunk. CS mail? (This still isn't checked in on the branch.)
tpreston@netscape.com, could you verify the bug on the trunk build before pav will check this into the 0.9.2 branch? thanks
pav, could you check this into 0.9.2 branch?
Please see bugscape 7180 (http://bugscape.netscape.com/show_bug.cgi?id=7180) for why this should not be pushed to the branch at this time.
Looks like a good one to take. Nominating for PDT+.
Whiteboard: fixed on trunk → PDT, fixed on trunk
We would like to take a good fix on the 0.9.4 branch if possible (all concerns in bugscape bug are addressed). Per pdt mtg.
Keywords: nsbranch+
this fix is already in 0.9.4.. marking fixed (removing nsbranch+ since this was pre-0.9.4 branch). we'll leave the bugscape bug open
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Keywords: nsbranch+
Resolution: --- → FIXED
Verified fixed on W98 build 2001-09-17-05-0.9.4
Verified linux build 2001-09-17-05-0.9.4 Verified Mac OS X build 2001-17-04-0.9.4 Verified W2k 2001-09-17-05-0.9.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: