Clean up obsolete GTK code

RESOLVED FIXED in mozilla24

Status

()

Core
Widget: Gtk
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Timothy Arceri, Assigned: Timothy Arceri)

Tracking

Trunk
mozilla24
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
This bug is for two things:

1. To remove old GTK_CHECK_VERSION/gtk_check_version for versions of GTK already covered by the minimum GTK build requirement 2.10.

2. To remove depreciated GDK_ROOT_PARENT()
(Assignee)

Comment 1

4 years ago
Created attachment 755616 [details] [diff] [review]
Remove old gtk check versions

Patch to remove old GTK_CHECK_VERSION/gtk_check_version for versions of GTK already covered by the minimum GTK build requirement 2.10.
Attachment #755616 - Flags: review?(karlt)
Attachment #755616 - Flags: review?(karlt) → review+
(Assignee)

Updated

4 years ago
Attachment #755616 - Flags: checkin?
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

4 years ago
Created attachment 755807 [details] [diff] [review]
Replace old calls

Ok it turns out the remaining GDK_ROOT_PARENT() calls are inside a #if 0 in ./widget/gtk2/nsWindow.cpp

I have provided a patch to update this anyway. But should this code just be removed or is it still useful in some way?
Attachment #755807 - Flags: review?(karlt)
Attachment #755616 - Flags: checkin? → checkin+
https://hg.mozilla.org/integration/mozilla-inbound/rev/06c126ab69d3
Keywords: checkin-needed
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/06c126ab69d3
Comment on attachment 755807 [details] [diff] [review]
Replace old calls

(In reply to Timothy Arceri from comment #2)
> But should this code just be removed or is it still useful in some way?

I don't mind.  Looks like it is debugging code that might still work, but I haven't used it.  It won't work with GTK3.  If you'd like to remove the paint flashing code, I'd review it.
Attachment #755807 - Flags: review?(karlt) → review+
(Assignee)

Comment 6

4 years ago
Comment on attachment 755807 [details] [diff] [review]
Replace old calls

I'll just leave it alone for now.
Attachment #755807 - Flags: checkin?
(Assignee)

Updated

4 years ago
Whiteboard: [leave open] → check
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Whiteboard: check
Attachment #755807 - Flags: checkin? → checkin+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f73e297ed889
Assignee: nobody → t_arceri
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f73e297ed889
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.