877409 - Clean up obsolete GTK code

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Timothy Arceri]

This bug is for two things:

1. To remove old GTK_CHECK_VERSION/gtk_check_version for versions of GTK already covered by the minimum GTK build requirement 2.10.

2. To remove depreciated GDK_ROOT_PARENT()

Comment 1

[Timothy Arceri]

Attachment: Remove old gtk check versions

Patch to remove old GTK_CHECK_VERSION/gtk_check_version for versions of GTK already covered by the minimum GTK build requirement 2.10.

Comment 2

[Timothy Arceri]

Attachment: Replace old calls

Ok it turns out the remaining GDK_ROOT_PARENT() calls are inside a #if 0 in ./widget/gtk2/nsWindow.cpp

I have provided a patch to update this anyway. But should this code just be removed or is it still useful in some way?

Comment 3

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06c126ab69d3

Comment 4

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/06c126ab69d3

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 755807 [details] [diff] [review]
Replace old calls

(In reply to Timothy Arceri from comment #2)
> But should this code just be removed or is it still useful in some way?

I don't mind.  Looks like it is debugging code that might still work, but I haven't used it.  It won't work with GTK3.  If you'd like to remove the paint flashing code, I'd review it.

Comment 6

[Timothy Arceri]

Comment on attachment 755807 [details] [diff] [review]
Replace old calls

I'll just leave it alone for now.

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f73e297ed889

Comment 8

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/f73e297ed889