877412 - [traceback] TypeError: 'Response' object does not support item assignment - mkt.api.middleware in process_response

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: API, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/14347/

mkt.api.middleware in process_response
TypeError: 'Response' object does not support item assignment

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 188, in get_response
    response = middleware_method(request, response)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 307, in wrapper
    return wrapped(*args, **kwargs)
  File "mkt/api/middleware.py", line 76, in process_response
    'X-HTTP-Method-Override, Content-Type')

Comment 1

[Andy McKay]

This is a result of ES 500'ing, not the cause.

Comment 3

[Rob Hudson [:robhudson]]

Looks like it happens in a lot of places according to sentry:
http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/14347/

Bumping priority

Comment 4

[David Larlet [:davidbgk]]

This error used to happen when the returned response is not a Django response (but a dict or a list for instance). I can't confirm given that I don't have access to sentry.

Comment 5

[Mathieu Pillard [:mat]]

Looked at this for while today and I'm puzzled.

From the errors in sentry it seems to happen when somehow one of our middlewares is called on an 'Http404' exception or a tastypie 'Response' object instead of a regular HttpResponse class, but I can't reproduce this: in both cases shown in sentry, I have a correct HttpResponse locally (django's HttpResponseNotFound or tastypie's HttpApplicationError).

It hasn't happened in 3 months, and it was an edge case to begin with, so I vote downgrade priority or close the bug for now.

Comment 6

[Mathieu Pillard [:mat]]

Closing as we no longer use tastypie, so I doubt this bug is still relevant (and we haven't seen it in a while anyway). Re-open if this comes back.