877413 - Add an addPath to toolkit/loader

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dave Camp (:dcamp)]

We want the devtools server loader to load all extensions to the server in its own loader, for a few reasons:

a) We want to be able to identify all globals associated with the loader so we can avoid debugging ourselves during chrome debugging.
b) We want to be able to load multiple copies of the server so that we can debug the debugging server.

So we want tests and extensions to be able to add URIs that can be loaded.  A few options that would be acceptable are:

a) require("resource://fully/qualified/url");
b) defineModule(loader, "extensionpath/module", "resource://extensionuri/module.js"); require("extensionpath/module");
c) addPath(loader, "extensionpath/", "resource://extensionuri/"); require("extensionpath/module");

c) seems the simplest, so I'll send a pull request that does that.

Comment 1

[Dave Camp (:dcamp)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1012#attch-to-bugzilla

Pointer to Github pull-request

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Want to assign this to Irakli for a review, Dave?

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 755623 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1012#attch-to-bugzilla

Yeah, got distracted.

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 755623 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1012#attch-to-bugzilla

Removing review request for now since after chatting on IRC dcamp decide to try using `resolve` + `mapping` instead.

Dave feel free to re-request if that'll becomes more complicated than necessary.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Dave, is this still needed for dev tools?

Comment 6

[Dave Camp (:dcamp)]

I'm not sure we still need this - we can reopen if we do.