877469 - Add "Switch to Tab" functionality to BookmarksPage

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Switch to Tab was removed by Bug 862796. Add it back to bookmarks-page.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Show the icon

This shows an icon if there is an url already opened.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 760658 [details] [diff] [review]
Part 1: Show the icon

Review of attachment 760658 [details] [diff] [review]:
-----------------------------------------------------------------

The reliance on the Tabs singleton all over the place is a bit unfortunate. But I guess this has to be fixed in a separate bug.

::: mobile/android/base/Tabs.java
@@ +604,5 @@
> +     * @return true if the url is open currently, false otherwise.
> +     */
> +    public boolean hasUrl(String url) {
> +        for (Tab tab : mOrder) {
> +            if (TextUtils.equals(tab.getURL(), url))

nit: I prefer to always use {}'s, even on one-line if's.

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/projects/fig/rev/478e2819dbf7

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/95d4652040a6