877495 - [B2G] [Browser] Crash upon attempt to display 3D images

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Deepa Subramanian]

Attachment: Logcat for Inari

Description:
When the user taps on the molecule links, the browser crashes (Crash report links provided in the notes). 

Repro Steps:
1. Updated to Leo Build ID: 20130529070208
2. Launch Browser app
3. Go to http://bit.ly/css3d-mol
4. Select any of the links at the bottom of the page (Caffine, Salt, Buckyball or Graphite)

Expected: Browser displays 3D images of the molecule

Actual: Browser Crashes

Environmental  Variables:
Device : Leo
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6ca32ed2bbc6
Gaia: 8f5ab7bfd4a2921aab4e2de11e0d79a29c1bb062

Also tested on,
Inari Build ID: 20130528070209 
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/611d727390a4 
Gaia: 5f499ab1e4a274d3d28e20139c9cdc546dc4fc69

Notes:
Repro frequency: 100%
See attached: logcat and crash reports.
Crash report links:
LEO: https://crash-stats.mozilla.com/report/index/6d813581-32c3-461f-8042-78ce32130529
INARI: https://crash-stats.mozilla.com/report/index/ba3937f9-b134-40cc-adb5-000c52130529

Comment 1

[Deepa Subramanian]

Attachment: Logcat for LEO

Comment 2

[Sotaro Ikeda [:sotaro]]

In the log, there is the following log. So it failed because of "Too many open files". Though current num of fd limit is 4096. It seem that num of fd did not hit 4096. Hmm.

> E/memalloc(135): /dev/pmem: Failed to initialize pmem sub-heap: -1
> W/memalloc(135): Falling back to ashmem
> E/memalloc(135): couldn't create ashmem (Too many open files)
> E/msm7627a.gralloc(135): gralloc failed err=Too many open files
> W/GraphicBufferAllocator(135): alloc(64, 57, 1, 00000133, ...) failed -24 (Too many open files)
> E/memalloc(1684): /dev/pmem: Failed to map buffer size:11972608 offset:11956224 fd:1656 Error: Out of memory

Comment 3

[Jason Smith [:jsmith]]

Looks like a Shadow Layers crash.

Comment 4

[Sotaro Ikeda [:sotaro]]

By using following command, I confirmed that b2g process's fd number becomes more than 4096 :-(
> watch --interval=1 "adb shell ls /proc/144/fd | wc -w"

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - change file descriptor's limit to 8192

Comment 6

[Sotaro Ikeda [:sotaro]]

I applied attachment 755771 [details] [diff] [review] to buri and leo device. Results are following. I see the problem because of file descriptor limit. 8192 is enough for the site, I think.
- buri: no crash happend
- leo: app crash happend because of out of memory.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: logcat of leo after applying attachment 755771

The crash happened on leo after applying attachment 755771 [details] [diff] [review]. The crash is not related to file descriptor limit. Just becomes out of memory.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)
> Created attachment 755771 [details] [diff] [review]
> patch - change file descriptor's limit to 8192

attachment 755771 [details] [diff] [review] is enough to fix file descriptor limit problem.

Comment 9

[Sotaro Ikeda [:sotaro]]

Comment on attachment 755771 [details] [diff] [review]
patch - change file descriptor's limit to 8192

mwu, can you review the patch?

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 755771 [details] [diff] [review]
patch - change file descriptor's limit to 8192

Is there a bug open for limiting the maximum number of layers?

Comment 11

[Sotaro Ikeda [:sotaro]]

(In reply to Michael Wu [:mwu] from comment #10)
> Comment on attachment 755771 [details] [diff] [review]
> patch - change file descriptor's limit to 8192
> 
> Is there a bug open for limiting the maximum number of layers?

There is no actual bug for it. I am going to create it.

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #11)
> > 
> > Is there a bug open for limiting the maximum number of layers?
> 
> There is no actual bug for it. I am going to create it.

Bug 877557 created.

Comment 13

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - change file descriptor's limit to 8192

change to use only one "ulimit".

Comment 14

[Sotaro Ikeda [:sotaro]]

I misunderstood about "ulimit" in android. The default "ulimit" try to set both soft limit and hard limit. I am not sure why "ulimit -n 8192" did not change hard limit :-(

http://androidxref.com/4.0.4/xref/system/core/sh/miscbltin.c#344

Comment 15

[Sotaro Ikeda [:sotaro]]

I confirmed attachment 755805 [details] [diff] [review] on buri and leo device.

Comment 16

[Sotaro Ikeda [:sotaro]]

Comment on attachment 755805 [details] [diff] [review]
patch v2 - change file descriptor's limit to 8192

mwu, can you review the patch again?

Comment 17

[Sotaro Ikeda [:sotaro]]

Attachment: link to pull request

Comment 18

[Michael Wu [:mwu]]

Pull request was merged.

Comment 19

[Michael Wu [:mwu]]

Uplifted.

https://github.com/mozilla-b2g/gonk-misc/commit/eb3cb7229ceea275b358268e91a459ba4f795777

Comment 20

[:CSchmoeckel]

Added Browser Suite Test Case #8524 [Browser] The Browser App displays 3D images on websites without crashing

Comment 21

[Deepa Subramanian]

The browsers crashes when the user taps on the Graphite /YBCO superconductor/ buckyball.

This issue is appearing on found on leo build.

Leo Build ID: 20130610070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

Comment 22

[Deepa Subramanian]

The browser still crashes when the user taps on the any of the molecules present in the last row (Graphite /YBCO superconductor/ buckyball).

This issue is appearing on found on leo build.

Leo Build ID: 
Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1
RIL Version: 01.01.00.019.138

Comment 23

[Sotaro Ikeda [:sotaro]]

(In reply to Deepa Subramanian from comment #22)
> The browser still crashes when the user taps on the any of the molecules
> present in the last row (Graphite /YBCO superconductor/ buckyball).
> 
> This issue is appearing on found on leo build.
> 
> Leo Build ID: 
> Build ID: 20130625070217
> Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
> Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
> Platform Version: 18.1
> RIL Version: 01.01.00.019.138

Can you get the logcat of the crash?

Comment 24

[Sotaro Ikeda [:sotaro]]

I checked the crash on leo device. The crash happened because of out of memory. It is a different problem from the file descriptor limit that solved in this bug.

Comment 25

[Sotaro Ikeda [:sotaro]]

Created Bug 889966 for the crash because of out of memory.

Comment 26

[Sotaro Ikeda [:sotaro]]

Bug 889957 is created to gather bugs related to  http://threejs.org/examples/css3d_molecules.html performance problems

Comment 27

[John Hammink]

Crash is resolved:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d
Gaia   e2ef782119b7e79fc62c48d36f0c36909d982988
BuildID 20130712070210
Version 18.0